bug#1173: gnus/imap.el should quote quotes in password

bug#1173: gnus/imap.el should quote quotes in password

[Aaron D. Ball]

When sending a LOGIN command, the imap-login-auth function in imap.el 
does not quote double quotes in the password string, so passwords 
containing double quotes result in an error.

I'm using stock Emacs 22.3, compiled by our sysadmin team here:

GNU Emacs 22.3.2 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll 
bars) of 2008-09-26 on node106

Below is the patch I am using, which fixed the problem for me:

--- lisp/gnus/imap.el~      2008-01-06 20:22:42.000000000 -0500
+++ lisp/gnus/imap.el       2008-10-15 13:58:06.124586000 -0400
@@ -922,7 +922,7 @@
                           (lambda (user passwd)
                             (imap-ok-p (imap-send-command-wait
                                         (concat "LOGIN \"" user "\" \""
-                                               passwd "\""))))))
+ 
(replace-regexp-in-string "\"" "\\\"" passwd) "\""))))))

  (defun imap-anonymous-p (buffer)
    t)

-- 
Aaron D. Ball <adb@broad.mit.edu>
Senior Systems Analyst
Broad Institute of MIT and Harvard

bug#1173: Acknowledgement (gnus/imap.el should quote quotes in password)

[Aaron D. Ball]

I was mistaken about that patch fixing the problem.  It had a syntax 
error, so I didn't get the IMAP server error message, just an Emacs 
error message that went by fast enough that I missed it.

If someone can provide a patch that (unlike mine) actually works, I'd 
appreciate that.  In the meantime I'll see if I can figure out elisp 
string replacement again---it's been a while.

-- 
Aaron D. Ball <adb@broad.mit.edu>
Senior Systems Analyst
Broad Institute of MIT and Harvard

bug#1173: Acknowledgement (gnus/imap.el should quote quotes in password)

[Aaron D. Ball]

Looks like all I needed was to specify that the replacement is literal. 
  This patch let me read my mail for real.

--- lisp/gnus/imap.el~  2008-01-06 20:22:42.000000000 -0500
+++ lisp/gnus/imap.el   2008-10-15 14:58:40.890800000 -0400
@@ -922,7 +922,7 @@
                           (lambda (user passwd)
                             (imap-ok-p (imap-send-command-wait
                                         (concat "LOGIN \"" user "\" \""
-                                               passwd "\""))))))
+ 
(replace-regexp-in-string "\"" "\\\"" passwd t t) "\""))))))

  (defun imap-anonymous-p (buffer)
    t)


-- 
Aaron D. Ball <adb@broad.mit.edu>
Senior Systems Analyst
Broad Institute of MIT and Harvard

Re: bug#1173: Acknowledgement (gnus/imap.el should quote quotes in password)

[Ted Zlatanov]

On Wed, 15 Oct 2008 15:00:22 -0400 "Aaron D. Ball" <adb@broad.mit.edu> wrote: 

ADB> Looks like all I needed was to specify that the replacement is
ADB> literal. This patch let me read my mail for real.

ADB> --- lisp/gnus/imap.el~  2008-01-06 20:22:42.000000000 -0500
ADB> +++ lisp/gnus/imap.el   2008-10-15 14:58:40.890800000 -0400
ADB> @@ -922,7 +922,7 @@
ADB>                           (lambda (user passwd)
ADB>                             (imap-ok-p (imap-send-command-wait
ADB>                                         (concat "LOGIN \"" user "\" \""
ADB> -                                               passwd "\""))))))
ADB> + (replace-regexp-in-string "\"" "\\\"" passwd t t) "\""))))))

ADB>  (defun imap-anonymous-p (buffer)
ADB>    t)

Aaron,

the latest CVS Gnus and Emacs have:

(defun imap-quote-specials (string)
  (with-temp-buffer
    (insert string)
    (goto-char (point-min))
    (while (re-search-forward "[\\\"]" nil t)
      (forward-char -1)
      (insert "\\")
      (forward-char 1))
    (buffer-string)))

(it gets called for user name, password, etc. and escapes backslash as
well)

I think that will solve your problem, if you can use a more recent Emacs
or Gnus.

Thanks
Ted