From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#1061: pop-up-frames does not work on a tty Date: Fri, 03 Oct 2008 13:51:04 +0200 Message-ID: <48E60728.9080207@gmx.at> References: <200810010840.m918eNXF002502@mothra.ics.uci.edu> <48E37A78.50804@gmx.at> <200810011520.m91FKd1Q003547@mothra.ics.uci.edu> <48E3BF6A.9070602@gmx.at> <200810011856.m91IuPAT012990@mothra.ics.uci.edu> <48E49567.2070802@gmx.at> Reply-To: martin rudalics , 1061@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060302000607060102090705" X-Trace: ger.gmane.org 1223035815 29100 80.91.229.12 (3 Oct 2008 12:10:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Oct 2008 12:10:15 +0000 (UTC) Cc: 1061@emacsbugs.donarmstrong.com, Dan Nicolaescu To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 03 14:11:13 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KljV0-0002k9-MI for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 14:11:11 +0200 Original-Received: from localhost ([127.0.0.1]:40462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KljTx-0007o3-20 for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 08:10:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KljTt-0007nv-2e for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 08:10:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KljTr-0007nc-CS for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 08:09:59 -0400 Original-Received: from [199.232.76.173] (port=33398 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KljTr-0007nZ-6G for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 08:09:59 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:59826) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KljTq-0000re-N7 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 08:09:59 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93C9u8W001031; Fri, 3 Oct 2008 05:09:56 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m93C02G3030405; Fri, 3 Oct 2008 05:00:02 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 03 Oct 2008 12:00:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1061-submit@emacsbugs.donarmstrong.com id=B1061.122303472829040 (code B ref 1061); Fri, 03 Oct 2008 12:00:02 +0000 Original-Received: (at 1061) by emacsbugs.donarmstrong.com; 3 Oct 2008 11:52:08 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m93Bq2VK029034 for <1061@emacsbugs.donarmstrong.com>; Fri, 3 Oct 2008 04:52:05 -0700 Original-Received: (qmail invoked by alias); 03 Oct 2008 11:51:56 -0000 Original-Received: from 62-47-54-80.adsl.highway.telekom.at (EHLO [62.47.54.80]) [62.47.54.80] by mail.gmx.net (mp017) with SMTP; 03 Oct 2008 13:51:56 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/6antV6+v6ttExFKtEfSFJrjBvKb/Wk9jg6cbTIv lcMxn+uzkP+zuE User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.82,0.58 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 03 Oct 2008 08:09:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21031 Archived-At: This is a multi-part message in MIME format. --------------060302000607060102090705 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > Yes, the more I think of it, the more I feel like pop-up-frames) should > be ignored on ttys (and maybe special-display-buffers as well). Why throw out the child with the bathwater? We could have `raise-frame' simply select its argument on text-only terminals. martin --------------060302000607060102090705 Content-Type: text/plain; name="1061.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="1061.diff" *** frame.c.~1.394.~ 2008-09-30 19:36:42.968750000 +0200 --- frame.c 2008-10-03 13:47:18.171875000 +0200 *************** *** 2004,2010 **** If FRAME is invisible or iconified, make it visible. If you don't specify a frame, the selected frame is used. If Emacs is displaying on an ordinary terminal or some other device which ! doesn't support multiple overlapping frames, this function does nothing. */) (frame) Lisp_Object frame; { --- 2004,2010 ---- If FRAME is invisible or iconified, make it visible. If you don't specify a frame, the selected frame is used. If Emacs is displaying on an ordinary terminal or some other device which ! doesn't support multiple overlapping frames, this function selects FRAME. */) (frame) Lisp_Object frame; { *************** *** 2016,2023 **** f = XFRAME (frame); ! /* Do like the documentation says. */ ! Fmake_frame_visible (frame); if (FRAME_TERMINAL (f)->frame_raise_lower_hook) (*FRAME_TERMINAL (f)->frame_raise_lower_hook) (f, 1); --- 2016,2027 ---- f = XFRAME (frame); ! if (FRAME_TERMCAP_P (f)) ! /* On a text-only terminal select FRAME. */ ! Fselect_frame (frame); ! else ! /* Do like the documentation says. */ ! Fmake_frame_visible (frame); if (FRAME_TERMINAL (f)->frame_raise_lower_hook) (*FRAME_TERMINAL (f)->frame_raise_lower_hook) (f, 1); --------------060302000607060102090705--