From: martin rudalics <rudalics@gmx.at>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 1061@emacsbugs.donarmstrong.com
Subject: bug#1061: pop-up-frames does not work on a tty
Date: Wed, 01 Oct 2008 15:05:28 +0200 [thread overview]
Message-ID: <48E37598.2030209@gmx.at> (raw)
In-Reply-To: <200810010840.m918eNXF002502@mothra.ics.uci.edu>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
> With the current CVS HEAD:
>
> emacs -Q -nw
> M-: (setq pop-up-frames t) RET
> C-h f ding RET
>
> The *Help* buffer does not appear at this point, a new frame is created,
> but the current frame does not show the help buffer.
I'm aware of this problem. Does the attached patch fix it?
> with emacs-22.2 the *Help* buffer is displayed.
Not here on Windows. And I wonder how this could work on your system.
FWIW, the underlying logic did not change.
Does `pop-to-buffer' for some arbitrary, non-visible buffer work with
-nw? What happens with `display-buffer'?
martin
[-- Attachment #2: 1061.diff --]
[-- Type: text/plain, Size: 959 bytes --]
*** window.el.~1.153.~ 2008-09-13 10:14:15.250000000 +0200
--- window.el 2008-10-01 14:51:12.437500000 +0200
***************
*** 987,994 ****
buffer (if (listp pars) pars))))))
((or pop-up-frames (not frame-to-use))
;; We want or need a new frame.
! (window--display-buffer-2
! buffer (frame-selected-window (funcall pop-up-frame-function))))
((and pop-up-windows
;; Make a new window.
(or (not (frame-parameter frame-to-use 'unsplittable))
--- 987,997 ----
buffer (if (listp pars) pars))))))
((or pop-up-frames (not frame-to-use))
;; We want or need a new frame.
! (setq frame-to-use (funcall pop-up-frame-function))
! (prog1
! (window--display-buffer-2
! buffer (frame-selected-window frame-to-use))
! (select-frame-set-input-focus frame-to-use)))
((and pop-up-windows
;; Make a new window.
(or (not (frame-parameter frame-to-use 'unsplittable))
next prev parent reply other threads:[~2008-10-01 13:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48EDC1F2.4050305@gmx.at>
2008-10-01 8:40 ` bug#1061: pop-up-frames does not work on a tty Dan Nicolaescu
2008-10-01 13:05 ` martin rudalics [this message]
2008-10-01 15:57 ` Dan Nicolaescu
2008-10-01 13:26 ` martin rudalics
2008-10-01 15:20 ` Dan Nicolaescu
2008-10-01 15:20 ` Dan Nicolaescu
2008-10-01 18:20 ` martin rudalics
2008-10-01 18:56 ` Dan Nicolaescu
2008-10-02 9:33 ` martin rudalics
2008-10-02 12:45 ` Stefan Monnier
2008-10-03 11:51 ` martin rudalics
2008-10-03 13:09 ` Stefan Monnier
2008-10-03 13:41 ` martin rudalics
2008-10-06 14:02 ` Stefan Monnier
2008-10-06 16:31 ` martin rudalics
2008-10-03 17:06 ` Eli Zaretskii
2008-10-06 14:06 ` Stefan Monnier
2008-10-09 8:45 ` bug#1061: marked as done (pop-up-frames does not work on a tty) Emacs bug Tracking System
2008-10-09 0:51 bug#1061: pop-up-frames does not work on a tty Chong Yidong
2008-10-09 1:59 ` Stefan Monnier
2008-10-09 8:33 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E37598.2030209@gmx.at \
--to=rudalics@gmx.at \
--cc=1061@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.