From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.bugs Subject: bug#810: 23.0.60; atomic-change-group narrowing problem Date: Mon, 01 Sep 2008 23:53:06 +0200 Message-ID: <48BC6442.2060608@gmail.com> References: <48B6F562.9060006@gmail.com> <48BC2CE6.2070108@gmx.at> <48BC5C9D.9000008@gmx.at> Reply-To: "Lennart Borgman \(gmail\)" , 810@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1220306878 26174 80.91.229.12 (1 Sep 2008 22:07:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Sep 2008 22:07:58 +0000 (UTC) Cc: 810@emacsbugs.donarmstrong.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 02 00:08:52 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KaHZo-0002AT-8d for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Sep 2008 00:08:48 +0200 Original-Received: from localhost ([127.0.0.1]:58127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaHYp-0004D3-BO for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Sep 2008 18:07:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaHYd-0004A0-Js for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 18:07:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaHYb-00049c-Ul for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 18:07:35 -0400 Original-Received: from [199.232.76.173] (port=46291 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaHYb-00049Z-LD for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 18:07:33 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50846) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KaHYb-0004cT-1V for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 18:07:33 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81M7UBZ003918; Mon, 1 Sep 2008 15:07:30 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m81M03kd032676; Mon, 1 Sep 2008 15:00:03 -0700 X-Loop: don@donarmstrong.com Resent-From: "Lennart Borgman (gmail)" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 22:00:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 810 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 810-submit@emacsbugs.donarmstrong.com id=B810.122030599830672 (code B ref 810); Mon, 01 Sep 2008 22:00:03 +0000 Original-Received: (at 810) by emacsbugs.donarmstrong.com; 1 Sep 2008 21:53:18 +0000 Original-Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81LrFE5030666 for <810@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 14:53:16 -0700 Original-Received: from c83-254-151-87.bredband.comhem.se ([83.254.151.87]:61325 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KaHKj-0008WI-9D; Mon, 01 Sep 2008 23:53:14 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: <48BC5C9D.9000008@gmx.at> X-Enigmail-Version: 0.95.7 X-Antivirus: avast! (VPS 080901-0, 2008-09-01), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.87 X-Scan-Result: No virus found in message 1KaHKj-0008WI-9D. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KaHKj-0008WI-9D fa9e9c8a51d90238322ced7b9753aebf X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Mon, 01 Sep 2008 18:07:35 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19995 Archived-At: martin rudalics wrote: >>>> When using atomic-change-group I got the message >>>> undo-more: Changes to be undone are outside visible portion of buffer >>>> The changes are also not undone. This seems wrong to me. >> >>> The attached patch now also tries to restore any narrowing in force >>> before the atomic change. >> >> I'm not sure we should do that. Currently, narrowing operations are not >> saved to the undo-log, so making atomic-change-group save&restore the >> narrowing makes it behave differently from the undo. > > I know what you mean but the present case is different. When someone > uses narrowing within the atomic change group and we really want to undo > the changes (we still can decide that we won't fix the bug ;-)) we have > to widen the buffer. If the buffer was narrowed _before_ entering the > atomic change group, it would be incorrect not to restore that. Or am I > missing something? I agree. It would be very surprising if narrowing was not restored.