From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#818: 23.0.60; error when window-size-change-functions is a buffer-local hook Date: Sun, 31 Aug 2008 11:00:50 +0200 Message-ID: <48BA5DC2.2090108@gmx.at> References: <48B95651.4010305@gmx.at> Reply-To: martin rudalics , 818@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1220174885 3887 80.91.229.12 (31 Aug 2008 09:28:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 Aug 2008 09:28:05 +0000 (UTC) Cc: 818@emacsbugs.donarmstrong.com To: Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 31 11:28:59 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KZjEt-0003ew-AF for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Aug 2008 11:28:55 +0200 Original-Received: from localhost ([127.0.0.1]:48992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZjDu-0006jC-KU for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Aug 2008 05:27:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZjDc-0006bD-Fy for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 05:27:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZjDZ-0006Zl-Sn for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 05:27:35 -0400 Original-Received: from [199.232.76.173] (port=39308 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZjDZ-0006ZW-KZ for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 05:27:33 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49423) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KZjDY-0007Qb-5p for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 05:27:32 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7V9RUnN000900; Sun, 31 Aug 2008 02:27:30 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7V9A5uw027331; Sun, 31 Aug 2008 02:10:05 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 31 Aug 2008 09:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 818 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 818-submit@emacsbugs.donarmstrong.com id=B818.122017341524619 (code B ref 818); Sun, 31 Aug 2008 09:10:04 +0000 Original-Received: (at 818) by emacsbugs.donarmstrong.com; 31 Aug 2008 09:03:35 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m7V93Ue3024555 for <818@emacsbugs.donarmstrong.com>; Sun, 31 Aug 2008 02:03:32 -0700 Original-Received: (qmail invoked by alias); 31 Aug 2008 09:03:24 -0000 Original-Received: from 62-47-51-29.adsl.highway.telekom.at (EHLO [62.47.51.29]) [62.47.51.29] by mail.gmx.net (mp068) with SMTP; 31 Aug 2008 11:03:24 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18AIy10624AAxyhsNe9n3rkwMhWydIanLggmHARbO tTULWK8cmaHov4 User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.7 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Sun, 31 Aug 2008 05:27:35 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19926 Archived-At: >> Does the attached patch fix it? > > Yes, thank you. Once it is fixed in trunk, could you please apply the > following patch to linum.el? Thank you! I hopefully checked it in. Please have a look. > + (add-hook 'window-size-change-functions 'linum-after-size nil t) My fix only makes sure that Emacs does not issue an error when calling a function in `window-size-change-functions' and one of these functions was earlier added buffer-locally. But I'm not sure whether this DTRT when the value is buffer-local. If it doesn't, we might have to fix it as Stefan did for `window-configuration-change-hook' just with the frame argument added. Please have a look at this issue. You might also want to look at the thread "Wrong window end reported after splitting window" on emacs-devel around the beginning of this year. martin