all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 810@emacsbugs.donarmstrong.com
Subject: bug#810: 23.0.60; atomic-change-group narrowing problem
Date: Thu, 28 Aug 2008 23:37:26 +0200	[thread overview]
Message-ID: <48B71A96.4040700@gmail.com> (raw)
In-Reply-To: <48B71820.7040108@gmx.at>

martin rudalics wrote:
>> When using atomic-change-group I got the message
>>
>>   undo-more: Changes to be undone are outside visible portion of buffer
> 
> This message is usually a consequence of narrowing the buffer within the
> body of `atomic-change-group' or afterwards.
> 
>> The changes are also not undone. This seems wrong to me.
> 
> If you did narrow the buffer this is normal and not specific to
> `atomic-change-group'.

Maybe, but what is specific to atomic-change-group is that the doc
string says

  Perform body as an atomic change group.
  This means that if body exits abnormally,
  all of its changes to the current buffer are undone.

AFAICS there is something wrong either in the doc string or in the function.

I would suggest that this is a bug in the function. Think for example of
the case that you want to test something during narrowing and be sure
that the buffer is not changed.






  reply	other threads:[~2008-08-28 21:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <48C3A6BE.8030305@gmx.at>
2008-08-28 18:58 ` bug#810: 23.0.60; atomic-change-group narrowing problem Lennart Borgman (gmail)
2008-08-28 21:26   ` martin rudalics
2008-08-28 21:37     ` Lennart Borgman (gmail) [this message]
2008-08-29  9:27       ` martin rudalics
2008-09-01 17:56   ` martin rudalics
2008-09-01 20:43     ` Stefan Monnier
2008-09-01 21:20       ` martin rudalics
2008-09-01 21:53         ` Lennart Borgman (gmail)
2008-09-02  2:38           ` Stefan Monnier
2008-09-07  9:37             ` martin rudalics
2008-09-02 14:13         ` Richard M. Stallman
2008-09-07 10:15   ` bug#810: marked as done (23.0.60; atomic-change-group narrowing problem) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B71A96.4040700@gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=810@emacsbugs.donarmstrong.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.