all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Drew Adams <drew.adams@oracle.com>
Cc: 669@emacsbugs.donarmstrong.com
Subject: bug#669: 23.0.60; defalias is not taken into account by C-h k
Date: Wed, 13 Aug 2008 23:17:08 +0200	[thread overview]
Message-ID: <48A34F54.9090302@gmx.at> (raw)
In-Reply-To: <001d01c8fd69$da11c450$c2b22382@us.oracle.com>

 > Not completely fixed yet, because it doesn't say anything about where `foo' is
 > defined (assuming it is defined in a file somewhere).

If it is "defined in a file somewhere" you can jump to `foo' and see
where it is defined.  IIUC your assumption was that it's been defined
and evaluated in a buffer only.

 > If you could add that,
 > that would be great. The point is that we do want to send the user to the source
 > code, but not to the original `lisp-complete-symbol' source code.

If it's defined in a file we can send the user to the source code in the

   (defalias 'lisp-complete-symbol 'foo)

case via the `foo' indirection but certainly _not_ in the

   (defalias 'lisp-complete-symbol (symbol-function 'foo))

because, well, look at the return value of (symbol-function 'foo).

 > We also need to be sure that the `foo' doc string is used. In my test example I
 > omitted that.

In the indirection case follow the link to `foo' and get its doc-string
from there.  In the `symbol-function' case you simply have to provide
your own doc-string via the third arg of `defalias'.

 > And both of these cases need to be treated:
 >
 > (defalias 'lisp-complete-symbol 'foo)
 > (defalias 'lisp-complete-symbol (symbol-function 'foo))

I suppose I posted the *Help* output for both cases.

martin







  reply	other threads:[~2008-08-13 21:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07 18:23 bug#669: 23.0.60; defalias is not taken into account by C-h k Drew Adams
2008-08-07 20:54 ` Drew Adams
2008-08-13 17:05   ` martin rudalics
2008-08-13 17:27     ` Drew Adams
2008-08-13 21:17       ` martin rudalics [this message]
2008-08-13 21:41         ` Drew Adams
2008-08-14  6:18           ` martin rudalics
2008-08-14 15:33             ` Drew Adams
2008-08-14 20:03             ` Stefan Monnier
2008-08-14 20:00         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A34F54.9090302@gmx.at \
    --to=rudalics@gmx.at \
    --cc=669@emacsbugs.donarmstrong.com \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.