Re: [ELPA] propose to add vundo.el to ELPA

[Yuan Fu <casouri@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

>> 
>> diff --git a/elpa-packages b/elpa-packages
>> index e218968e87..8fb17c4baf 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -630,6 +630,12 @@
>> ("vertico-posframe"
>> :url "https://github.com/tumashu/vertico-posframe"
>> :auto-sync t)
>> + ("vundo"
>> + :url "https://github.com/casouri/vundo"
>> + :ignored-files ("test")
>> + :doc "README.txt"
> ^
> I am assuming this is supposed to be a :readme, not a :doc.
> Or do you actually want to create a manual out of the README?

That should be README.

> 
> As your commentary section seems to intentionally mirror the
> README (if this is the right thing is a different question. I
> don't know why a package.el user is interested in testing if the
> testing code isn't bundled in the package), this could just be
> dropped.

Should I let ELPA ignore README.txt and only use Commentary then?

> 
>> + :news "NEWS.txt"
> 
> I see that your README also contains a news section. It might make
> sense only maintain the news in one of the two, to avoid duplication on
> elpa.gnu.org.
> 
> Besides that, it seems to be that the introduction in README.txt doesn't
> immediately explain what the package is about. This might confuse
> people using C-h P to preview the package before installing it.

Thanks. I fixed those points and here is the new patch. In this patch I removed README.txt. If it turns out to be not desirable, I can make another patch.

Yuan


[-- Attachment #2: vundo.patch --]
[-- Type: application/octet-stream, Size: 860 bytes --]

From 8fac9d0caf324f1320ee99d9cdf421c50e30ac4d Mon Sep 17 00:00:00 2001
From: Yuan Fu <casouri@gmail.com>
Date: Tue, 5 Apr 2022 21:21:07 -0700
Subject: [PATCH] * elpa-packages ("vundo"): New package.

---
 elpa-packages | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index e218968e87..c6970f77b6 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -630,6 +630,11 @@
  ("vertico-posframe"
   :url "https://github.com/tumashu/vertico-posframe"
   :auto-sync t)
+ ("vundo"
+  :url "https://github.com/casouri/vundo"
+  :ignored-files ("test" "README.txt")
+  :news "NEWS.txt"
+  :auto-sync t)
  ("wcheck-mode"		:url "https://github.com/tlikonen/wcheck-mode")
  ("wconf"		:url "https://github.com/ilohmar/wconf")
  ("web-server"		:url "https://github.com/eschulte/emacs-web-server.git")
-- 
2.33.1


[-- Attachment #3: Type: text/plain, Size: 2 bytes --]