Re: Failure bootstrapping Emacs (Cygwin)

[Angelo Graziosi <angelo.graziosi@alice.it>]

Angelo Graziosi ha scritto:
> Current trunk fails in this waY:
> 
> [...]
> term.o: In function `dissociate_if_controlling_tty':
> /work/emacs/src/term.c:3216: undefined reference to `_EMACS_GET_TTY_PGRP'
> emacs.o: In function `shut_down_emacs':
> /work/emacs/src/emacs.c:2031: undefined reference to `_EMACS_GET_TTY_PGRP'
> callproc.o: In function `child_setup':
> /work/emacs/src/callproc.c:1257: undefined reference to 
> `_EMACS_SET_TTY_PGRP'
> collect2: ld returned 1 exit status
> make[1]: *** [temacs.exe] Error 1
> make[1]: Leaving directory `/work/build/src'
> make: *** [src] Error 2
> 
> This does not happen with trunk of a few hours before.
> 


> Perhaps this changes are the cause:
> 
> 2008-07-31  Dan Nicolaescu  <xxx@xxx>
> 
>     * bitmaps/README:
>     * xfns.c:
>     * termcap.c:
>     * term.c:         <==
>     * syswait.h:
>     * systty.h:
>     * systime.h:
>         [...]
> 
^^^^^^^ wrong ! ^^^^^^^^^^^^^^

This is the cause:

2008-07-30  Dan Nicolaescu  <xxxx@xxxx>

         * systty.h (sensemode): Remove empty #if.  Remove reference to
         BSD_TERMIOS, unused.

Restoring to systty.h:

#if defined (HAVE_TERMIOS) && ! defined (BSD_TERMIOS) 	
	  	
#define EMACS_GET_TTY_PGRP(fd, pgid) (*(pgid) = tcgetpgrp ((fd))) 	
#define EMACS_SET_TTY_PGRP(fd, pgid) (tcsetpgrp ((fd), *(pgid))) 	
	  	
#else
...

#endif /*BSD_TERMIOS*/

works! i.e. applying:

$ cat /tmp/systty.h.diff
--- systty.h.orig       2008-07-31 18:07:05.000000000 +0200
+++ systty.h    2008-07-31 18:16:28.109375000 +0200
@@ -188,12 +188,20 @@

  #ifdef EMACS_HAVE_TTY_PGRP

+#if defined (HAVE_TERMIOS) && ! defined (BSD_TERMIOS)
+
+#define EMACS_GET_TTY_PGRP(fd, pgid) (*(pgid) = tcgetpgrp ((fd)))
+#define EMACS_SET_TTY_PGRP(fd, pgid) (tcsetpgrp ((fd), *(pgid)))
+
+#else
+
  #ifdef TIOCSPGRP

  #define EMACS_GET_TTY_PGRP(fd, pgid) (ioctl ((fd), TIOCGPGRP, (pgid)))
  #define EMACS_SET_TTY_PGRP(fd, pgid) (ioctl ((fd), TIOCSPGRP, (pgid)))

  #endif /* TIOCSPGRP */
+#endif /*BSD_TERMIOS*/

  #else /* not EMACS_SET_TTY_PGRP */

> Cheers,
>    Angelo.
>