From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: inputting characters by hexadigit Date: Thu, 24 Jul 2008 23:30:12 +0200 Message-ID: <4888F464.90304@gmail.com> References: <868ww3vydn.fsf@lifelogs.com> <87mykhz6tf.fsf@jurta.org> <87tzeokrku.fsf@jurta.org> <87od4wgg8p.fsf@catnip.gol.com><86od4vmi5i.fsf@lifelogs.com> <873am6n21q.fsf@jurta.org> <87sku5if8t.fsf_-_@jurta.org> <87od4sti4g.fsf@jurta.org><867ibcekf3.fsf@lifelogs.com> <86tzegcq15.fsf@lifelogs.com> <86bq0nctbv.fsf@lifelogs.com> <86r69jb8z2.fsf@lifelogs.com> <005a01c8edae$beff6480$0ab32382@us.oracle.com> <008001c8edcb$b5276120$0ab32382@us.oracle.com> <4888E819.3050500@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1216935043 21661 80.91.229.12 (24 Jul 2008 21:30:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jul 2008 21:30:43 +0000 (UTC) Cc: 'Stefan Monnier' , emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 24 23:31:32 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KM8PG-0006b1-9Z for ged-emacs-devel@m.gmane.org; Thu, 24 Jul 2008 23:31:26 +0200 Original-Received: from localhost ([127.0.0.1]:54361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KM8OM-0004vc-GA for ged-emacs-devel@m.gmane.org; Thu, 24 Jul 2008 17:30:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KM8OI-0004vN-2K for emacs-devel@gnu.org; Thu, 24 Jul 2008 17:30:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KM8OG-0004vB-Kb for emacs-devel@gnu.org; Thu, 24 Jul 2008 17:30:25 -0400 Original-Received: from [199.232.76.173] (port=41822 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KM8OG-0004v8-EU for emacs-devel@gnu.org; Thu, 24 Jul 2008 17:30:24 -0400 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]:39753) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KM8OF-0000KA-Kn for emacs-devel@gnu.org; Thu, 24 Jul 2008 17:30:24 -0400 Original-Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:62487 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KM8OA-0007G8-3Z; Thu, 24 Jul 2008 23:30:18 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: <4888E819.3050500@gmail.com> X-Antivirus: avast! (VPS 080724-1, 2008-07-24), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KM8OA-0007G8-3Z. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1KM8OA-0007G8-3Z 852fdd9fc88b45f9cb073d27adb09423 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101423 Archived-At: Lennart Borgman (gmail) wrote: > Drew Adams wrote: >>>>>>>>> How about having `completing-read' just call a >>>>>>>>> `completing-read-function' variable if non-nil? >>>>>>>>> This is the same thing that `read-file-name' does, >>>>>>>>> with `read-file-name-function'. >>>>>>>> It sounds useful to authors of Emacs extensions and might even >>>>>>>> be useful directly for end users, letting >>>>>>>> them decide what completing-read function they feel >>>>>>>> like using on any particular day. >>>>>>> I agree. Is there any reason not to add completing-read-function? >>>>>> No one has objected to the idea. >>>>>> Could someone please implement this? >>>> Let's wait when Stefan moves completing-read to minibuffer.el and >>>> then just add >>>> (if completing-read-function >>>> (funcall completing-read-function ;-) >> >> >> SM> I'm not opposed to such a change, but I have other things >> SM> to do. So if someone else wants to install such a thing, >> SM> he should go right ahead. >> >> I hope someone will please do that. Thanks. > > Could not this be done by just renaming the C function completing-read > to completing-read-1 and then adding > > (defun completing-read (prompt > collection > &optional predicate require-match > initial-input hist def > inherit-input-method) > ... documentation ... > (if completing-read-function > (funcall completing-read-function ...) > (completing-read-1 ...))) > > to minibuffer.el? If implemented like this then completing-read-1 and completing-read will have identical argument lists. How should the doc strings for those functions be handled in a case like this? Is it ok to refer from completing-read to completing-read-1 and keep the full doc in the C code? (I guess it is very useful in the C code as a comment to the code.)