From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Finding the source of Change Log entries Date: Sun, 13 Jul 2008 10:33:59 +0200 Message-ID: <4879BDF7.6060705@gmx.at> References: <48787A1F.1080105@gmx.at> <873amfm9xj.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1215938086 931 80.91.229.12 (13 Jul 2008 08:34:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Jul 2008 08:34:46 +0000 (UTC) Cc: emacs-devel To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 13 10:35:33 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KHx3H-0005HV-39 for ged-emacs-devel@m.gmane.org; Sun, 13 Jul 2008 10:35:27 +0200 Original-Received: from localhost ([127.0.0.1]:44448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHx2P-0005nQ-1r for ged-emacs-devel@m.gmane.org; Sun, 13 Jul 2008 04:34:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KHx1c-0005ZU-De for emacs-devel@gnu.org; Sun, 13 Jul 2008 04:33:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KHx1Y-0005Xt-QX for emacs-devel@gnu.org; Sun, 13 Jul 2008 04:33:43 -0400 Original-Received: from [199.232.76.173] (port=49017 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHx1Y-0005Xo-J7 for emacs-devel@gnu.org; Sun, 13 Jul 2008 04:33:40 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]:39832) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KHx1Y-0005b4-8u for emacs-devel@gnu.org; Sun, 13 Jul 2008 04:33:40 -0400 Original-Received: (qmail invoked by alias); 13 Jul 2008 08:33:38 -0000 Original-Received: from 62-47-38-0.adsl.highway.telekom.at (EHLO [62.47.38.0]) [62.47.38.0] by mail.gmx.net (mp008) with SMTP; 13 Jul 2008 10:33:38 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/jI8wnqWDjA2H/veQgnGDy9KQq/qNZW0uQ83IxvA 4F3ZUd+TGSpoP3 User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <873amfm9xj.fsf@stupidchicken.com> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.72 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100635 Archived-At: > Please check it in, with the appropriate ChangeLog and NEWS > entries, plus the following fix: > > + (message "Not found `%s' in %s" tag file) > > should be something more grammatical, like > > + (message "Source location not found: `%s' in %s" tag file) > > Also, instead of binding change-log-find-tag to C-c C-t, how about using > C-c C-c for consistency with diff-mode? (You might also want to rename > change-log-find-tag to change-log-goto-source for consistency with > diff-goto-source, but that's your call.) Done. Please check again.