From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Thu, 10 Sep 2020 11:05:24 -0400 Message-ID: <4869c79f-2f3b-cafb-0459-c6f39f9a6bd5@cornell.edu> References: <5889C6B4.8060506@gmx.at> <588A0102.7010704@gmx.at> <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> <588C5003.4070409@gmx.at> <87r1rhbu2s.fsf@gnus.org> <83wo18pvoh.fsf@gnu.org> <17a425a3-7b6e-56bc-40a3-35ac78fdaa6a@gmx.at> <56ee5ed9-fd85-b5c3-6aba-d51332398f03@cornell.edu> <818f2053-a996-7ade-c1cf-6592b6d2cde5@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 Cc: Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, Noam Postavsky To: martin rudalics , Dani Moncayo , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 17:07:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGOAL-00012i-Bc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 17:07:13 +0200 Original-Received: from localhost ([::1]:36584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGOAK-0003OG-Ee for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 11:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGO9C-0002Wl-9f for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 11:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGO9C-0005NR-0J for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 11:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGO9B-000611-Q8 for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 11:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.159975033423077 (code B ref 25542); Thu, 10 Sep 2020 15:06:01 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 10 Sep 2020 15:05:34 +0000 Original-Received: from localhost ([127.0.0.1]:40927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGO8k-000609-AG for submit@debbugs.gnu.org; Thu, 10 Sep 2020 11:05:34 -0400 Original-Received: from mail-dm6nam12on2126.outbound.protection.outlook.com ([40.107.243.126]:63393 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGO8i-0005zw-RP for 25542@debbugs.gnu.org; Thu, 10 Sep 2020 11:05:33 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MrGEXTg4NNj4JBTaFb7BSyE1y1ZAatUSEy5SriqTgChXvJSqspf0zvhfiW+I6kyGFUTXt/XEgmJb22P3JSkYUEZ1+in96YK4FfSXHRXnWX+DC+80h4fE6nK8tYjL2B+5wLh9+lLqePRde5X7jRP9xBTJl6VPVf8DcgNhO84dJp4U2C3x9IK/cgiPknxDCnfYT8bptQ/ROCbi55KK8HiEbX3xBFxeE84ral4J+Ca9d5PsY1Ie2Kiv0mdtVsYc0IZWuW7CotvzIqQoBVHmEJ1ZMLh+BoLIkajbc4bBilGJdXk8dAwipng3CuBWLq5ZxJB5ljNxf/42TZGLXUonLcnKDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PVX7mlB3YDnxaPR2+WClMCwlRrmXJY2p/LzY2kRJRYc=; b=bDtMs8LNsTUZFpxkh+9wSpZNka3HGJtfSGfM22ZE3r+F1ZsjuOqtC3Y464CcJzIbPtsx4upwCIKhOHC9TprZSnHUfxrC043brzenkRIPLMo1tnUv8TlxmzinB2Eyzk6Jzisb29vHMxKMPyxHMBn2roDw/KceIZhZu6tULrQPHIjDm3qokqHyWJwNVsPAMfgoJMts/DOub5b1szr72WV9nzuhb2VeQwK8t9jrw8b7SDOA8sNOHjuMU7ibx2HMRADX+3Vs60uGwXr/ydmJC30E2UnKh96oT1DOFTjfkeUwI0pDbP3LIhYx6LmpLO/bgIJAg9ENKHKXF8xTK42nK1+t9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PVX7mlB3YDnxaPR2+WClMCwlRrmXJY2p/LzY2kRJRYc=; b=FIF1nUG5pwul8ovNEh10UybnWyNKlN+vq+hPG5kW4LmKYh40uPsKcSSwE1ho3KJiTOZnqOiMaPCwf9+VS6mbXip8ReqVUdJTfgZVE1E5qD+z4b+3Fe2/POvfZS4jc2fwvnPeEl2vgoxxmUPMB50+i7FumvgQXW51TwzBetacGqg= Authentication-Results: users.sourceforge.net; dkim=none (message not signed) header.d=none; users.sourceforge.net; dmarc=none action=none header.from=cornell.edu; Original-Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB5661.namprd04.prod.outlook.com (2603:10b6:208:a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Thu, 10 Sep 2020 15:05:26 +0000 Original-Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::c144:d206:c369:af44]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::c144:d206:c369:af44%7]) with mapi id 15.20.3348.017; Thu, 10 Sep 2020 15:05:26 +0000 In-Reply-To: <818f2053-a996-7ade-c1cf-6592b6d2cde5@gmx.at> Content-Language: en-US X-ClientProxiedBy: CH2PR03CA0011.namprd03.prod.outlook.com (2603:10b6:610:59::21) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from [IPv6:2604:6000:b407:7f00:ad88:231:3482:1c42] (2604:6000:b407:7f00:ad88:231:3482:1c42) by CH2PR03CA0011.namprd03.prod.outlook.com (2603:10b6:610:59::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Thu, 10 Sep 2020 15:05:25 +0000 X-Originating-IP: [2604:6000:b407:7f00:ad88:231:3482:1c42] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47a05c63-ecf9-494f-6184-08d8559af29b X-MS-TrafficTypeDiagnostic: MN2PR04MB5661: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EWrcULVGVo4Q9ah4snn+BoABCeSFSkjZM2JoLngJoWsquHmFPiWFwcNyxr3MrMDBs8/MdXxNV40ZbYm9HCchXXwPu0UlF2sZWZ+GaL2loQ5SvqiPxFwRtrIidIgCH812YqgCCJkZjLDb9DB8Eka91yJBu80vMk6UxSVd/hv1wpuWlfZJBISjZeC0YWJdhjloxIYx0bW/3qzPN1eYRmCfu3P4xJIeDPfeFfs+Ye1UCZjxQo62tk50bKDOaW6KV25E0xVkfupro+FxZxwdIORH28yFmNZy8ljpMacZh+uown8Ieyt6qZCwYpdzxj8sn2OES6z4FGhB2FFHMHlL1x0Igva6x4t392X/zEZUbWMU1cIZWW315FItEkHVXeLJ7plQeL3W9ZeVGFIDmuZfNh401A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(2616005)(54906003)(53546011)(52116002)(110136005)(2906002)(8676002)(186003)(75432002)(478600001)(6486002)(8936002)(316002)(83380400001)(66946007)(786003)(31686004)(4326008)(5660300002)(66556008)(86362001)(36756003)(66476007)(31696002)(16526019)(14963001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: Ysq8gn8dXXB0mW9xZrxVZ6cVskcQm/MEY94gvVg4ZmjS4oNdaWJvTVlleSLwZ5QZfNiwX1+++2MroHddAjH7xRQ4b4Fy3ros6VjLWxzqWSG7qE3228hy7BCUsx3f7C1Im025ZDcmqR4mXGDvuB1HeV8MCEW6b7QNO5mTyCQILG8gOy/rJzRdOQbI54wsABW+3oaBC4A5REAnnpwV5yH0OHBQym3zPRleRoCUHMoZ3yOwcoglhQQf5RerR6julifPLJKdB/bsbR16XXlSaUx2FS3V6kcW09wONE37fMxTH3p1X8YQ6L6+PfnebOLddwLDpcPgZ8EV3khZclTnNa8OcQm+VjlquBlOSrOlmBWLBnCwnyOEsXkK3wgJ2dXGcdkU+KwIKNgI8TZMwgyNZNhbRx8rE5Sfn8sKI6Qr8MV6xKJzU5COIxaIuz22xNprxZXfADg05BhQT1Af0537/usvVpBnHk4EnzUSEaz1R3G1XBAk+ATZEOsnF0q8ixAZcrTYwbg3hohyfHtWzZ41TGdbe6qfw8YorKe0Axyo8yoCBfQWUfWPN7dtAwZaEasj+iDdSzbhc8sNyaINoilupLr8qqYMWEheDVhDmONtsqa1u+2Rn7zF+MolScFdj6bmpVwT/UpzThciumxnlcPCjyJpHgLfHafSzNPH2DguCpBcnn4rl8ucIpEIz43hq9l+qMjIC1q1QoV4L99SL37ZHjfM7w== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 47a05c63-ecf9-494f-6184-08d8559af29b X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2020 15:05:25.8657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V/PcXAjNjxtQpuf6IKy/YRdQxnwhX0xeH81urMC9RWWu/CaWx4PUdH7zswI7QzfjmkgpSTF0rGa76IdrZoYf0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5661 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187740 Archived-At: On 9/10/2020 3:16 AM, martin rudalics wrote: > >> I just tried this on a Cygwin-w32 build from the master branch.  I put the > taskbar on the left, started emacs, maximized it, attached gdb, put breakpoints > at each of the ShowWindow lines, and ran through Dani's recipe for producing the > bug.  The breakpoints were never hit. > > > > I just tried again, but this time with a breakpoint at w32fullscreen_hook so > that I could follow the flow.  Here are the relevant excerpts from the gdb session: > > Thank you very much for checking. > > > Breakpoint 2 at 0x10069507a: file ../../master/src/w32term.c, line 6441. > > (gdb) r -Q > > Starting program: /home/kbrown/src/emacs/x86_64-w32/src/emacs -Q > > > > [...] > > > > [Press F11] > > > > Thread 1 "emacs" hit Breakpoint 2, w32fullscreen_hook (f=0x8001f7c88) > >      at ../../master/src/w32term.c:6441 > [...] > > 6464          FRAME_PREV_FSMODE (f) = f->want_fullscreen; > > (gdb) p f->want_fullscreen > > $1 = FULLSCREEN_BOTH > > While this is the expected value ... > > > [...] > > > > (gdb) c > > Continuing. > > > > [Press F11 again] > > > > Thread 1 "emacs" hit Breakpoint 2, w32fullscreen_hook (f=0x8001f7c88) > >      at ../../master/src/w32term.c:6441 > [...] > > 6451          if (FRAME_PREV_FSMODE (f) == FULLSCREEN_NONE) > > (gdb) p f->want_fullscreen > > $2 = FULLSCREEN_NONE > > ... the value I would have expected here is FULLSCREEN_MAXIMIZED. > Something must have got broken before.  Can you please > > (1) Verify that the > >       f->want_fullscreen &= ~FULLSCREEN_WAIT; > >     does not interfere in any respect.  That is, does f->want_fullscreen >     have the same value FULLSCREEN_NONE before anding it with >     FULLSCREEN_WAIT? Yes. > (2) Does 'toggle-frame-fullscreen' the second time when you type F11 >     correctly call > >    (set-frame-parameter frame 'fullscreen fullscreen-restore) > >    with 'fullscreen-restore' equal to 'maximized' at all? No. The value of 'fullscreen-restore' is nil. But if I repeat the experiment with the taskbar on the bottom, the value of fullscreen-restore is 'maximized'. > (3) Verify that calling w32fullscreen_hook with the taskbar on the >     bottom does hit the breakpoints and subsequently maximize the frame >     as expected. With the taskbar on the bottom, f->want_fullscreen == FULLSCREEN_MAXIMIZED when I hit line 6449 after the second F11, and everything goes as expected after that. Ken