From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Bj=C3=B6rn?= Bidar Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Sat, 04 Jan 2025 03:22:52 +0200 Message-ID: <48607.1074892365$1735953833@news.gmane.org> References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <083310b3-a288-5c75-c835-84595e134682@gmail.com> <56c9eadd95367cd3fd7c8414dc3e86b243a4b3d7.camel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , emacs-devel@gnu.org, Jonas Bernoulli To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 04 02:23:46 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTstF-0001l4-Je for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jan 2025 02:23:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTssW-0001UB-Is; Fri, 03 Jan 2025 20:23:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTssU-0001Tw-25 for emacs-devel@gnu.org; Fri, 03 Jan 2025 20:22:58 -0500 Original-Received: from thaodan.de ([2a03:4000:4f:f15::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTssR-0006He-Md for emacs-devel@gnu.org; Fri, 03 Jan 2025 20:22:57 -0500 Original-Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id DF371D00049; Sat, 4 Jan 2025 03:22:52 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1735953773; bh=eXkMReT7CsM/MViFMcELcG46jBseNDd8O5Hfi9wlN04=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=kZPeoYb52XPQwtgEddR/U/3yfnN63ZiubEutyEp2/CsPbckZTfJg47Zuoex+/Mb5A 945cDnL+NOBgWhnV8vBCCT5V349JeJ5D4et212fOsp8GQo45xpFfmU+965+MXwqR9S afdb/kT2AezgkIiPTnPThZTKNzj59TmaIUCzVs4sUbyy5CdYKkbwNS80dp5clApn8b nOyvfLMVO04Ekmb+x0iNq3N/PLJKVB1MZEHISuID658ieDH/3SryLNzMFgB3h9+LdR 89CRVifleOP2z0wqh7ATcm7MuoqCgzjaW0hGxJLLL9dFcnnq3Kn88bCPYjwd5Wa3z5 pex9dWlsF5W0oAXTPqygT4SSx628wsxnoH4kiwJK01f95eF7TapMFl7Tc7fcPOKTs7 aiSnbRVIz+BczZvdZXj6Ib/Roa0LHjUjh8pIANAgMPFfo1oD+Mw8Y7RPWualBo9+r2 uOnPcdAil9ss7QNK+jM763ZBNUbAFJnHgeO5Ko4+uJFJVoNpzbyWnosbiFCQYS1JaY Z9xENzpYxAEvfmPIFCTM7usc5fT2nG/6S8xv3oH5HDdM29T/t7q18JJ5HFNmXyhzVx 1UlemsUSrLwg9tmHVcODaPi2a2lJlvpW0GPnxIcDKx8t/YTyzoZuW5+rIdRO8O48FG +XkWx/xoflYDHizEaOc0ebuk= In-Reply-To: <56c9eadd95367cd3fd7c8414dc3e86b243a4b3d7.camel@yandex.ru> (Konstantin Kharlamov's message of "Sat, 04 Jan 2025 01:52:45 +0300") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH Received-SPF: pass client-ip=2a03:4000:4f:f15::1; envelope-from=bjorn.bidar@thaodan.de; helo=thaodan.de X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327643 Archived-At: Konstantin Kharlamov writes: > On Fri, 2025-01-03 at 23:14 +0200, Bj=C3=B6rn Bidar wrote: >> Jim Porter writes: >>=20 >> > On 1/2/2025 10:30 AM, Konstantin Kharlamov wrote: >> > > But Emacs seems to be the only widely popular editor that still >> > > doesn't >> > > provide OOTB at least syntax highlight for git-commit format. So, >> > > does >> > > anyone have opposition to adding a major mode that would be bound >> > > to >> > > filenames like `COMMIT_EDITMSG` and others, and would provide the >> > > aforementioned highlight? >> >=20 >> > For what it's worth, I wrote a very simple package to do this for >> > myself, since I don't use Magit. (I'm just so used to the Git >> > command >> > line that I've never taken the time to mess with Magit.) >> >=20 >>=20 >> Is there a way we can do this without reinventing the wheel? E.g. by >> including Jonas's git-commit mode into Emacs? > > Using Jim's mode comes as close as it gets to not reinventing the > wheel. As mentioned by Stefan elsewhere in the thread, Jonas' git- > commit that is part of magit can't be easily included for license > reasons. Most of the code was written by Jonas. If either the other authors code is replaced or they have also assigned their copyright to the FSF it could be included. >> PS: It would be very beneficial to not uses Github for Emacs >> development but other FOSS platforms such as Codeberg. No need to >> feed >> Copilot with our code to copy it into other non-FOSS code. > > As mentioned by Dick, Emacs is mirrored to Github anyway. Dicks rather trolling comment aside, I don't think that is a reason to use Github. > search it seems neither Codeberg nor Gitlab has an active Emacs mirror, > right? > That means there's no other option besides Github for > contributors to store their local changes to before sending them > upstream. I don't see a problem there, create an account on which server you prefer a= nd fetch from Savannah. No need to use Github to download the Emacs repository. > Obviously, a new contributor wouldn't have an account to > git.savannah, and even if they do, git.savannah doesn't allow to fork a > repo, instead it requires to store everyone the changes to their local > branch on a shared repo, which seems unsafe on a bigger scale. This has nothing to do with Savannah, you don't have to "fork" a repository that's a Forge thing to map pull requests (and to easier map commit refs between the source and the fork but that's OT).