From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Eilert Newsgroups: gmane.emacs.devel Subject: Re: Darkening font-lock colors Date: Mon, 3 Aug 2009 11:21:48 -0300 Message-ID: <485b0c380908030721xa34e5c7tfeeca5b1f7734ec8@mail.gmail.com> References: <87d47hoox5.fsf@stupidchicken.com> <200907302139.n6ULdKCr008497@godzilla.ics.uci.edu> <87my6lrfzf.fsf@stupidchicken.com> <200907302221.n6UMLUWZ009001@godzilla.ics.uci.edu> <87hbwtisco.fsf@cyd.mit.edu> <200907310239.n6V2dFGY012065@godzilla.ics.uci.edu> <87iqh5ivn4.fsf@mail.jurta.org> <200908030344.n733iceT009655@godzilla.ics.uci.edu> <87skg9yw2v.fsf@mail.jurta.org> <200908031234.n73CYKlg013580@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001636c5b2f091868004703d7d32 X-Trace: ger.gmane.org 1249318051 28115 80.91.229.12 (3 Aug 2009 16:47:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Aug 2009 16:47:31 +0000 (UTC) Cc: Juri Linkov , Chong Yidong , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 03 18:47:23 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MY0gu-00040W-27 for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2009 18:47:16 +0200 Original-Received: from localhost ([127.0.0.1]:38202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MY0gt-0001cx-Ef for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2009 12:47:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXyQG-0003lf-Nj for emacs-devel@gnu.org; Mon, 03 Aug 2009 10:21:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXyQB-0003g6-Bm for emacs-devel@gnu.org; Mon, 03 Aug 2009 10:21:55 -0400 Original-Received: from [199.232.76.173] (port=37486 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXyQA-0003fs-Vx for emacs-devel@gnu.org; Mon, 03 Aug 2009 10:21:51 -0400 Original-Received: from mail-bw0-f222.google.com ([209.85.218.222]:51241) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXyQA-00026e-EQ for emacs-devel@gnu.org; Mon, 03 Aug 2009 10:21:50 -0400 Original-Received: by bwz22 with SMTP id 22so3180725bwz.42 for ; Mon, 03 Aug 2009 07:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=LvqsF4JWvdyeLpKZunxXXHVusLyoD2kX3ZhXcI5YsRM=; b=b7qUPuoyA5vhYFIVkTyLHcv1NkPQmGjV64L6BtDdJdVi+KU86qyc7V1TPRn4Vpg0fH 4NhfokwOIU2AT8ceuYZnMRFVPT4otjIIcQ2HcOaaeYSByN89fry8hK4EXGzjQJFjESW+ kQDCzfgE6/ZS0asSWnd5yrO8EcMKJEyFquXdA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=XwxrMGy2y3LQaS19vzp8xv5VjEWfsY2LDKKy3EPENBfA/zGP/HGMgI0JTcXT8yfHGf ksJ7kL+1iXBp+rIfZVd3HDGew+q6b/Fs0R5yC4g/8eAuHAp4gnt3jRVlcCBP3xVsn9zz QIRSOLoq5eeXoOsdKXcj8/XdzA9SV/cc7wd+4= Original-Received: by 10.223.111.71 with SMTP id r7mr2511643fap.59.1249309308847; Mon, 03 Aug 2009 07:21:48 -0700 (PDT) In-Reply-To: <200908031234.n73CYKlg013580@godzilla.ics.uci.edu> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113609 Archived-At: --001636c5b2f091868004703d7d32 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Is there anything preventing color-theme.el from being included in Emacs? That way themes could be provided to better account for particular user tastes. --Stephen programmer, n: A red eyed, mumbling mammal capable of conversing with inanimate monsters. On Mon, Aug 3, 2009 at 9:34 AM, Dan Nicolaescu wrote: > Juri Linkov writes: > > > > > > Given that you are changing faces, how about changing the dark > > > > > background, 8 color font-lock-comment-face to "yellow", then we > can > > > > > obsolete `font-lock-comment-delimiter-face'. > > > > > > > > Why yellow? > > > > > > It has good contrast with the black background and it is only used by > > > font-lock-variable-face on an 8 color dark background terminal. > > > > Then yellow would be good for font-lock-comment-face, but I think > > font-lock-comment-delimiter should stay in red. > > Why? font-lock-comment-delimiter is a hack. > And an unnecessary complication. > It was only introduced because the red foreground used on an 8 color > dark background terminal was not readable. > font-lock-comment-delimiter it is currently only used for 8 color dark > background terminals. > > The problem is that this is confusing for users: we got many bug reports > about syntax coloring not working because the users saw the body of the > comments not being syntax highlighted. Distributions (Debian, Ubuntu > and probably others too) patched this out by using red for > font-lock-comment-face, effectively defeating the purpose of why > font-lock-comment-delimiter was introduced. > > So I am proposing to simplify this whole thing by removing the reason > for font-lock-comment-delimiter to exist: use a readable yellow > foreground on 8 color dark background terminals. > > > --001636c5b2f091868004703d7d32 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Is there anything preventing color-theme.el from being included in Emac= s?=C2=A0 That way themes could be provided to better account for particular= user tastes.


--Stephen

programmer, n:
= =C2=A0 =C2=A0 =C2=A0 =C2=A0A red eyed, mumbling mammal capable of conversin= g with inanimate monsters.


On Mon, Aug 3, 2009 at 9:34 AM, Dan Nico= laescu <dann@ics.u= ci.edu> wrote:
Juri Linkov <juri@ju= rta.org> writes:

=C2=A0> > =C2=A0 > > G= iven that you are changing faces, how about changing the dark
=C2=A0> > =C2=A0 > > background, 8 color font-lock-comment-fac= e to "yellow", then we can
=C2=A0> > =C2=A0 > > obsolete `font-lock-comment-delimiter-fac= e'.
=C2=A0> > =C2=A0 >
=C2=A0> > =C2=A0 > Why yellow?
=C2=A0> >
=C2=A0> > It has good contrast with the black background and it is o= nly used by
=C2=A0> > font-lock-variable-face on an 8 color dark background term= inal.
=C2=A0>
=C2=A0> Then yellow would be good for font-lock-comment-face, but I thi= nk
=C2=A0> font-lock-comment-delimiter should stay in red.

Why? =C2=A0font-lock-comment-delimiter is a hack.
And an unnecessary complication.
It was only introduced because the red foreground used on an 8 color
dark background terminal was not readable.
font-lock-comment-delimiter it is currently only used for 8 color dark
background terminals.

The problem is that this is confusing for users: we got many bug reports about syntax coloring not working because the users saw the body of the
comments not being syntax highlighted. =C2=A0Distributions (Debian, Ubuntu<= br> and probably others too) patched this out by using red for
font-lock-comment-face, effectively defeating the purpose of why
font-lock-comment-delimiter was introduced.

So I am proposing to simplify this whole thing by removing the reason
for font-lock-comment-delimiter to exist: use a readable yellow
foreground on 8 color dark background terminals.



--001636c5b2f091868004703d7d32--