From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: `split-window-preferred-horizontally' Date: Tue, 10 Jun 2008 09:54:57 +0200 Message-ID: <484E3351.1090202@gmx.at> References: <87k5h28i23.fsf@localhorst.mine.nu> <4849B3D7.6090809@gmx.at> <87fxrq198q.fsf@localhorst.mine.nu> <484A451C.2010408@gmx.at> <8763sl0zma.fsf@localhorst.mine.nu> <484BD97D.1090205@gmx.at> <87ve0jzuj3.fsf@localhorst.mine.nu> <87zlpucors.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1213084583 23288 80.91.229.12 (10 Jun 2008 07:56:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Jun 2008 07:56:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Hansen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 10 09:57:06 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K5yiu-00081d-Ke for ged-emacs-devel@m.gmane.org; Tue, 10 Jun 2008 09:56:56 +0200 Original-Received: from localhost ([127.0.0.1]:55545 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5yi7-00026v-9s for ged-emacs-devel@m.gmane.org; Tue, 10 Jun 2008 03:56:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K5yi2-00026Q-57 for emacs-devel@gnu.org; Tue, 10 Jun 2008 03:56:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K5yi0-000264-FE for emacs-devel@gnu.org; Tue, 10 Jun 2008 03:56:01 -0400 Original-Received: from [199.232.76.173] (port=33008 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5yi0-00025v-82 for emacs-devel@gnu.org; Tue, 10 Jun 2008 03:56:00 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]:45865) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1K5yhz-0006GT-TR for emacs-devel@gnu.org; Tue, 10 Jun 2008 03:56:00 -0400 Original-Received: (qmail invoked by alias); 10 Jun 2008 07:55:58 -0000 Original-Received: from 62-47-36-149.adsl.highway.telekom.at (EHLO [62.47.36.149]) [62.47.36.149] by mail.gmx.net (mp067) with SMTP; 10 Jun 2008 09:55:58 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+AOFstReOAYB+fI+CanurUVsdUsuD5cuZMIYMLEX SqKdBqaFBdei/4 User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <87zlpucors.fsf@localhorst.mine.nu> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98849 Archived-At: > One annoyance left: when I have one frame split horizontally, then enter > the minibuffer and something triggers display of completions, the > completions are displayed in the window that was active before i entered > the minibuffer. Thanks for spotting. The bug occurs because I've been using `with-selected-window' when trying to split the least recently used window (the right window in your case) thus messing up that window's use_time. As a consequence the other window (the left window in your case) becomes the least recently used one and gets selected for displaying the completions. I've checked in a fix, please try again. I think `select-window' should avoid changing window_select_count when norecord is non-nil but maybe this could have unwanted side-effects.