From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7236: 24.0.50; make-local-hook missing Date: Tue, 19 Oct 2010 10:14:13 -0700 Message-ID: <4821966EA2454455B959B5CEC93EDD93@us.oracle.com> References: <87y69vbyrk.fsf@mail.eng.it><19644.32383.529459.435414@mail.eng.it> <20101018214207.GB3396@muc.de><9D100A0D59D34365AD1993719B18D9D6@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1287510187 5606 80.91.229.12 (19 Oct 2010 17:43:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 19 Oct 2010 17:43:07 +0000 (UTC) Cc: 7236@debbugs.gnu.org, saint@eng.it To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 19 19:43:04 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P8GD1-0001br-3o for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Oct 2010 19:42:59 +0200 Original-Received: from localhost ([127.0.0.1]:58675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8GCv-00020B-Dw for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Oct 2010 13:42:41 -0400 Original-Received: from [140.186.70.92] (port=40592 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8GCp-0001zc-Eb for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2010 13:42:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8GCn-0001xg-Um for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2010 13:42:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8GCn-0001xa-T3 for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2010 13:42:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P8FiI-0002Uw-GV; Tue, 19 Oct 2010 13:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2010 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7236-submit@debbugs.gnu.org id=B7236.12875082519596 (code B ref 7236); Tue, 19 Oct 2010 17:11:02 +0000 Original-Received: (at 7236) by debbugs.gnu.org; 19 Oct 2010 17:10:51 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8Fi6-0002Uj-DF for submit@debbugs.gnu.org; Tue, 19 Oct 2010 13:10:50 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8Fi5-0002Ub-1X for 7236@debbugs.gnu.org; Tue, 19 Oct 2010 13:10:49 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o9JHEX1D011158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Oct 2010 17:14:34 GMT Original-Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o9JHEVlm029855; Tue, 19 Oct 2010 17:14:32 GMT Original-Received: from abhmt002.oracle.com by acsmt353.oracle.com with ESMTP id 698113911287508461; Tue, 19 Oct 2010 10:14:21 -0700 Original-Received: from dradamslap1 (/10.159.219.37) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Oct 2010 10:14:20 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: ActvqzzH95smHOmwQmmSAPua9FsH+QAAl6Pg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 19 Oct 2010 13:11:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40993 Archived-At: > > In Emacs 20 also there is a LOCAL optional arg to add-hook. > > Yes, but its semantics is slightly different: it means "put it on the > local part of the hook, but only if that local part exists". > I.e. it's only effective if make-local-hook has been called before. > I changed this in Emacs-21 (it an incompatible change, but > didn't cause any bug report AFAIR) which made make-local-hook a NOP. > > > Should all code for Emacs 20-24 remove make-local-hook calls and > > instead add `t' to an existing call to add-hook? > > No. If the LOCAL arg is nil, add-hook will only affect the global part > of the hook, regardless of whether make-local-hook has been called. Glad I asked! I removed calls to make-local-hook yesterday, but put them back today in code that needs to work in Emacs 20. Thanks for the explanation. I see that you mentioned it in NEWS.21.