vc status

vc status

[Sam Steingold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have a few notes about vc status (under hg), current cvs head:

1. mouse2 does nothing, I think it should visit or mark the file,
depending on where I click (like in PCL-CVS).

2. q is bound to bury-buffer, it should be bound to quit-window instead
(like in dired and all other non-self-inserting modes).

thanks.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIBiPhPp1Qsf2qnMcRAjpHAJ9ARKa7H08LpycduBWh9DslF15+sACeI6LI
Wx0yYzkyfnILyK4On2hmBWc=
=2aNS
-----END PGP SIGNATURE-----

Re: vc status

[Dan Nicolaescu]

Sam Steingold <sds@gnu.org> writes:

  > I have a few notes about vc status (under hg), current cvs head:
  > 
  > 1. mouse2 does nothing, I think it should visit or mark the file,
  > depending on where I click (like in PCL-CVS).

From vc.el:

;;; Todo:

;; - vc-dir needs mouse bindings.

Patches are welcome!

  > 2. q is bound to bury-buffer, it should be bound to quit-window instead
  > (like in dired and all other non-self-inserting modes).

PCL-CVS calls bury-buffer (after doing some other processing), that
was the source of inspiration.  Get an OK from Stefan to change this.

Re: vc status

[Tom Tromey]

>>>>> "Dan" == Dan Nicolaescu <dann@ics.uci.edu> writes:

>> 2. q is bound to bury-buffer, it should be bound to quit-window instead
>> (like in dired and all other non-self-inserting modes).

Dan> PCL-CVS calls bury-buffer (after doing some other processing), that
Dan> was the source of inspiration.  Get an OK from Stefan to change this.

This is my error.  I had forgotten about quit-window when writing this
code, and I didn't realize that cvs-bury-buffer calls quit-window.
Perhaps cvs-bury-buffer is what we want, I'm not sure.

Tom

Re: vc status

[Stefan Monnier]

>> 2. q is bound to bury-buffer, it should be bound to quit-window instead
>> (like in dired and all other non-self-inserting modes).

> PCL-CVS calls bury-buffer (after doing some other processing), that
> was the source of inspiration.  Get an OK from Stefan to change this.

It's fine by me.


        Stefan

Re: vc status

[Stefan Monnier]

>>> 2. q is bound to bury-buffer, it should be bound to quit-window instead
>>> (like in dired and all other non-self-inserting modes).

Dan> PCL-CVS calls bury-buffer (after doing some other processing), that
Dan> was the source of inspiration.  Get an OK from Stefan to change this.

> This is my error.  I had forgotten about quit-window when writing this
> code, and I didn't realize that cvs-bury-buffer calls quit-window.
> Perhaps cvs-bury-buffer is what we want, I'm not sure.

I'd rather use quit-window.  `cvs-bury-buffer' is meant for secondary
buffers (like *diff* or *change-log*) so that when we leave them, we get
back to the *cvs* buffer.


        Stefan