From: Daniel Lopez <daniel.lopez999@gmail.com>
To: Tobias Bading <tbading@web.de>, 34479@debbugs.gnu.org
Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer
Date: Mon, 25 Feb 2019 16:03:58 +0000 [thread overview]
Message-ID: <47a35443-96a2-be73-1aed-8e85b91ed186@gmail.com> (raw)
In-Reply-To: <BC11BD75-B2C8-49A7-9D5C-3550BFD87B58@web.de>
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 146af5a..368b088 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1441,7 +1441,7 @@ compilation-parse-errors
> (let ((this-type (if (consp type)
> (compilation-type type)
> (or type 2))))
> - (compilation--note-type type)
> + (compilation--note-type this-type)
>
> (compilation--put-prop
> file 'font-lock-face
Hi Tobias,
Just verified it here - I agree, that should be changed as well.
(In fact, the copy of the function that's currently in my init file to
replace the original just for now, already has that extra change. Not
sure why that didn't make it into my original patch. Thanks for spotting.)
Daniel
next prev parent reply other threads:[~2019-02-25 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 16:00 bug#34479: Incorrect classification of messages in compilation-mode buffer Daniel Lopez
2019-02-14 16:05 ` Daniel Lopez
2019-02-15 8:02 ` Eli Zaretskii
2019-02-25 13:26 ` Tobias Bading
2019-02-25 16:03 ` Daniel Lopez [this message]
2019-03-01 10:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47a35443-96a2-be73-1aed-8e85b91ed186@gmail.com \
--to=daniel.lopez999@gmail.com \
--cc=34479@debbugs.gnu.org \
--cc=tbading@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.