From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: split-window-preferred-function Date: Wed, 19 Mar 2008 22:42:45 +0100 Message-ID: <47E188D5.5030502@gmx.at> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1205962950 1101 80.91.229.10 (19 Mar 2008 21:42:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Mar 2008 21:42:30 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 19 22:58:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1Jc6Ix-0005qw-Rt for ged-emacs-devel@m.gmane.org; Wed, 19 Mar 2008 22:58:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jc638-0001zk-QR for ged-emacs-devel@m.gmane.org; Wed, 19 Mar 2008 17:42:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jc634-0001x9-Av for emacs-devel@gnu.org; Wed, 19 Mar 2008 17:42:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jc632-0001sx-GY for emacs-devel@gnu.org; Wed, 19 Mar 2008 17:42:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jc632-0001sm-5F for emacs-devel@gnu.org; Wed, 19 Mar 2008 17:42:12 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Jc631-0004Cb-Ih for emacs-devel@gnu.org; Wed, 19 Mar 2008 17:42:11 -0400 Original-Received: (qmail invoked by alias); 19 Mar 2008 21:42:09 -0000 Original-Received: from N741P021.adsl.highway.telekom.at (EHLO [62.47.36.149]) [62.47.36.149] by mail.gmx.net (mp013) with SMTP; 19 Mar 2008 22:42:09 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19IZDZJBMlIWC2nkm8DyqTmW+9ydcDKQ1dFEakOWq L+2wdX0GBJr5GT User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:93011 Archived-At: `split-window-preferred-function' appears half-baked: In `display-buffer' its calls are preceded by things like && (window_height (window) >= split_height_threshold ... && (window_height (window) >= (2 * window_min_size_2 (XWINDOW (window), 0)))) Set to some horizontal splitting function, splitting will be wrongly rejected when the original window is not sufficiently high and wrongly accepted when the window is not wide enough. Hence it seems that we need something like `split-width-threshold' and a way to detect how `split-window-preferred-function' is going to split the window in order to know which of our checks should be applied.