From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Gustav_H=E5llberg?= Newsgroups: gmane.emacs.bugs Subject: vc-annotate-background customization is incorrect Date: Mon, 17 Mar 2008 16:08:16 +0100 Message-ID: <47DE8960.1030403@virtutech.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070402030805000700030004" X-Trace: ger.gmane.org 1205804306 8990 80.91.229.12 (18 Mar 2008 01:38:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Mar 2008 01:38:26 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 18 02:38:55 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JbQmz-0005Wf-7H for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Mar 2008 02:38:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JbQmP-0003G5-8a for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Mar 2008 21:38:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JbGwp-0007hh-PD for bug-gnu-emacs@gnu.org; Mon, 17 Mar 2008 11:08:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JbGwp-0007gi-0e for bug-gnu-emacs@gnu.org; Mon, 17 Mar 2008 11:08:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JbGwo-0007gY-Sz for bug-gnu-emacs@gnu.org; Mon, 17 Mar 2008 11:08:22 -0400 Original-Received: from dns.vtab.com ([62.20.90.195] helo=oden.vtab.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JbGwo-0008Ek-Ez for bug-gnu-emacs@gnu.org; Mon, 17 Mar 2008 11:08:22 -0400 Original-Received: from oden.vtab.com (oden.vtab.com [127.0.0.1]) by oden.vtab.com (Postfix) with ESMTP id 774C326F350; Mon, 17 Mar 2008 16:08:17 +0100 (CET) Original-Received: from lux.hq.vtech (lux.hq.vtech [10.0.0.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by oden.vtab.com (Postfix) with ESMTP id 4B7B426EFF6; Mon, 17 Mar 2008 16:08:17 +0100 (CET) User-Agent: Thunderbird 2.0.0.9 (X11/20071115) X-Virus-Scanned: ClamAV using ClamSMTP X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Mon, 17 Mar 2008 21:38:14 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17727 Archived-At: This is a multi-part message in MIME format. --------------070402030805000700030004 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In ftp://ftp.gnu.org/pub/gnu/emacs/emacs-22.1.tar.gz the (defcustom) for vc-annotate-background incorrectly only allows string values. A better choice would be to allow nil (for using the default background) or the "color" type. I attach a suggested patch. - Gustav --------------070402030805000700030004 Content-Type: text/x-patch; name="vc-annotate-background.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="vc-annotate-background.patch" --- emacs-22.1/lisp/vc.el~ 2007-05-14 16:56:29.000000000 +0200 +++ emacs-22.1/lisp/vc.el 2008-03-17 16:01:54.000000000 +0100 @@ -689,7 +689,7 @@ (defcustom vc-annotate-background "black" "Background color for \\[vc-annotate]. Default color is used if nil." - :type 'string + :type '(choice (const :tag "Default background" nil) (color)) :group 'vc) (defcustom vc-annotate-menu-elements '(2 0.5 0.1 0.01) --------------070402030805000700030004--