all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* vc-annotate-background customization is incorrect
@ 2008-03-17 15:08 Gustav Hållberg
  0 siblings, 0 replies; only message in thread
From: Gustav Hållberg @ 2008-03-17 15:08 UTC (permalink / raw)
  To: bug-gnu-emacs

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

In ftp://ftp.gnu.org/pub/gnu/emacs/emacs-22.1.tar.gz the (defcustom) for 
vc-annotate-background incorrectly only allows string values.

A better choice would be to allow nil (for using the default background) 
or the "color" type.

I attach a suggested patch.

- Gustav

[-- Attachment #2: vc-annotate-background.patch --]
[-- Type: text/x-patch, Size: 417 bytes --]

--- emacs-22.1/lisp/vc.el~	2007-05-14 16:56:29.000000000 +0200
+++ emacs-22.1/lisp/vc.el	2008-03-17 16:01:54.000000000 +0100
@@ -689,7 +689,7 @@
 (defcustom vc-annotate-background "black"
   "Background color for \\[vc-annotate].
 Default color is used if nil."
-  :type 'string
+  :type '(choice (const :tag "Default background" nil) (color))
   :group 'vc)
 
 (defcustom vc-annotate-menu-elements '(2 0.5 0.1 0.01)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-17 15:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-17 15:08 vc-annotate-background customization is incorrect Gustav Hållberg

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.