nxml-mode does not remove its overlays

nxml-mode does not remove its overlays

[Lennart Borgman (gmail)]

Could this be added to nxml.el?

;; This should be run in `change-major-mode-hook'."
;; Should be part of nxml.el IMO
(defun nxml-change-mode ()
   ;; Remove overlays used by nxml-mode.
   (save-excursion
     (unless (and (= (point-min) 1)
                  (= (point-max) (1+ (buffer-size))))
       (widen))
     (rng-validate-mode 0)
     (let ((inhibit-read-only t)
           (buffer-undo-list t)
           (modified (buffer-modified-p)))
       (nxml-with-invisible-motion
         (remove-text-properties (point-min) (point-max) '(face nil)))
       (set-buffer-modified-p modified))))

Re: nxml-mode does not remove its overlays

[Stefan Monnier]

>     (unless (and (= (point-min) 1)
>                  (= (point-max) (1+ (buffer-size))))
>       (widen))

Please just use `widen'.  It's not like it's expensive of anything.


        Stefan


PS: To check if a buffer is widened, please use
(= (buffer-size) (- (point-max) (point-min)))

Re: nxml-mode does not remove its overlays

[Bastien]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> PS: To check if a buffer is widened, please use
> (= (buffer-size) (- (point-max) (point-min)))

This is something I've already been looking for several times.

Maybe this could go in simple.el:

(defun buffer-narrowed-p
  "Return non-nil if the current buffer is narrowed."
  (not (= (buffer-size)
	  (- (point-max) 
	     (point-min)))

-- 
Bastien

Re: nxml-mode does not remove its overlays

[David Kastrup]

Bastien <bzg@altern.org> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> PS: To check if a buffer is widened, please use
>> (= (buffer-size) (- (point-max) (point-min)))
>
> This is something I've already been looking for several times.
>
> Maybe this could go in simple.el:
>
> (defun buffer-narrowed-p
>   "Return non-nil if the current buffer is narrowed."
>   (not (= (buffer-size)
> 	  (- (point-max) 
> 	     (point-min)))

Use /= rather than (not (= ... and a defsubst.  Of course, a defsubst
means that people are not free to change the buffer-size/point-min/max
semantics/invariants without having to recompile everything.

But I think I rather prefer if people have to work hard for a different
scenario...

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum