From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: compiler warning "comparison is always true" Date: Sat, 16 Feb 2008 23:05:15 +0000 Message-ID: <47B76C2B.8030209@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1203203166 31861 80.91.229.12 (16 Feb 2008 23:06:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2008 23:06:06 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 17 00:06:30 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQW6c-0005li-LR for ged-emacs-devel@m.gmane.org; Sun, 17 Feb 2008 00:06:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQW68-0005bl-Gm for ged-emacs-devel@m.gmane.org; Sat, 16 Feb 2008 18:05:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JQW64-0005be-IC for emacs-devel@gnu.org; Sat, 16 Feb 2008 18:05:28 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JQW63-0005b8-2i for emacs-devel@gnu.org; Sat, 16 Feb 2008 18:05:28 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQW62-0005b5-W6 for emacs-devel@gnu.org; Sat, 16 Feb 2008 18:05:27 -0500 Original-Received: from mk-outboundfilter-3.mail.uk.tiscali.com ([212.74.114.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JQW5v-0006qa-Sd; Sat, 16 Feb 2008 18:05:20 -0500 Original-X-Trace: 42234203/mk-outboundfilter-1.mail.uk.tiscali.com/F2S/$ACCEPTED/freedom2Surf-customers/83.67.23.108 X-SBRS: None X-RemoteIP: 83.67.23.108 X-IP-MAIL-FROM: jasonr@gnu.org X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CAK/6tkdTQxds/2dsb2JhbAAIjDKfcQ X-IP-Direction: OUT Original-Received: from i-83-67-23-108.freedom2surf.net (HELO [127.0.0.1]) ([83.67.23.108]) by smtp.f2s.tiscali.co.uk with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Feb 2008 23:05:18 +0000 User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) In-Reply-To: X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89281 Archived-At: Glenn Morris wrote: > Eli Zaretskii wrote: > > >> I think I fixed that as well. Please try. >> > > Works for me. Thanks! > > There was one more in fontset.c that I forgot to mention - I copied > what you did. > > Wasn't the compiler right though - isn't comparing against > MOST_POSITIVE_FIXNUM pointless? > Only on 64 bit platforms where MOST_POSITIVE_FIXNUM is larger than MAX_UINT.