From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: buffer is modified after commit Date: Wed, 13 Feb 2008 22:39:42 +0100 Message-ID: <47B3639E.9070007@gmx.at> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1202938870 3747 80.91.229.12 (13 Feb 2008 21:41:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Feb 2008 21:41:10 +0000 (UTC) Cc: Juanma Barranquero , Emacs Devel , Richard Sharman To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 13 22:41:32 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JPPLg-0005YB-QL for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2008 22:41:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JPPLD-0001is-2V for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2008 16:40:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JPPL8-0001iE-QW for emacs-devel@gnu.org; Wed, 13 Feb 2008 16:40:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JPPL8-0001hy-25 for emacs-devel@gnu.org; Wed, 13 Feb 2008 16:40:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JPPL7-0001hv-Pp for emacs-devel@gnu.org; Wed, 13 Feb 2008 16:40:25 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JPPL7-0001Hh-Cb for emacs-devel@gnu.org; Wed, 13 Feb 2008 16:40:25 -0500 Original-Received: (qmail invoked by alias); 13 Feb 2008 21:40:22 -0000 Original-Received: from N709P007.adsl.highway.telekom.at (EHLO [62.47.32.135]) [62.47.32.135] by mail.gmx.net (mp026) with SMTP; 13 Feb 2008 22:40:22 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/NBbcO3RrNzVF5ZS10pHuw8TNArU3l4oiYwVp9Gz plWSZCE5YtL2Lz User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:88981 Archived-At: > 3 - buffer-modified-p is incorrectly forcefully set to nil by the > special undo entries added in highlight-changes-rotate-faces. > That's correct if the buffer was not modified before undoing > this command, but is dangerous otherwise (will mark your buffer as > unmodified even though you haven't saved the changes). Yes, that part is tricky and should be solved by a generic primitive rather than my ad-hoc fix. I thought that when the buffer is unmodified at the time I do "this command", doing/undoing "this command" and setting the modified status to nil should not cause any harm. Can you provide a counterexample?