all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* assuming light or dark background
@ 2008-02-07 23:45 jidanni
  2008-02-08  2:53 ` Jason Rumney
  0 siblings, 1 reply; 4+ messages in thread
From: jidanni @ 2008-02-07 23:45 UTC (permalink / raw)
  To: bug-gnu-emacs; +Cc: fx

RFCs are unreadable now for me. Must be due to

  (defface rfcview-headlink-face
    '((t (:foreground "blue"))
      (t (:bold t)))
    "Face used for hyperlinks to headings."
    :group 'rfcview)

making some assumptions about the users' screen background color or
something. This points to a general emacs bug that there needs to be
an additional layer of indirection to soften the collision between
what the lisp author wants to do, and the environment where it ends up
getting done... without the user having to customize again for each
program... Indeed, I bet the half of all the .el authors in the world
assumed dark backgrounds and half assumed light backgrounds too!

There the problem should be attacked at its root, not by just telling
the user to

> Type M-x customize ...




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: assuming light or dark background
  2008-02-07 23:45 assuming light or dark background jidanni
@ 2008-02-08  2:53 ` Jason Rumney
  2008-02-22 17:19   ` Dave Love
  0 siblings, 1 reply; 4+ messages in thread
From: Jason Rumney @ 2008-02-08  2:53 UTC (permalink / raw)
  To: jidanni; +Cc: bug-gnu-emacs, fx

jidanni@jidanni.org wrote:
> RFCs are unreadable now for me. Must be due to
>
>   (defface rfcview-headlink-face
>     '((t (:foreground "blue"))
>       (t (:bold t)))
>     "Face used for hyperlinks to headings."
>     :group 'rfcview)
>   

This doesn't appear to be part of Emacs. Probably a better way of 
defining that face is

(defface rfcview-headlink-face
    '((t (:inherit 'link)))
    "Face used for hyperlinks to headngs."
    :group 'rfcview)

That way it will take advantage of any variations that already exist for 
the built-in link face, such as light, dark, grayscale, or user 
customizations.






^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: assuming light or dark background
  2008-02-08  2:53 ` Jason Rumney
@ 2008-02-22 17:19   ` Dave Love
  2008-02-23  0:41     ` jidanni
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Love @ 2008-02-22 17:19 UTC (permalink / raw)
  To: Jason Rumney; +Cc: bug-gnu-emacs, jidanni

Jason Rumney <jasonr@gnu.org> writes:

> jidanni@jidanni.org wrote:
>> RFCs are unreadable now for me. Must be due to
>>
>>   (defface rfcview-headlink-face
>>     '((t (:foreground "blue"))
>>       (t (:bold t)))
>>     "Face used for hyperlinks to headings."
>>     :group 'rfcview)
>>
>
> This doesn't appear to be part of Emacs.

Indeed.  It isn't part of
<URL:http://www.loveshack.ukfsn.org/emacs/rfcview.el> either.

> Probably a better way of
> defining that face is
>
> (defface rfcview-headlink-face
>    '((t (:inherit 'link)))
>    "Face used for hyperlinks to headngs."
>    :group 'rfcview)

(facep 'link)
  => nil

> That way it will take advantage of any variations that already exist
> for the built-in link face, such as light, dark, grayscale, or user
> customizations.

If there was a face defined for hyperlinks in the relevant versions of
Emacs, it would be appropriate just to use it (with the `face' custom
type), not define more vanity faces.  That was what we intended for
Emacs 21 as far as I remember, even if it didn't get done well.  I
shouldn't have 281 separately-defined faces in my current session --
Gnus being the biggest culprit.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: assuming light or dark background
  2008-02-22 17:19   ` Dave Love
@ 2008-02-23  0:41     ` jidanni
  0 siblings, 0 replies; 4+ messages in thread
From: jidanni @ 2008-02-23  0:41 UTC (permalink / raw)
  To: fx, 464940; +Cc: bug-gnu-emacs

DL> Indeed.  It isn't part of
DL> <URL:http://www.loveshack.ukfsn.org/emacs/rfcview.el> either.
All I know is
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=464940
Hope you all can work it out.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-02-23  0:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-07 23:45 assuming light or dark background jidanni
2008-02-08  2:53 ` Jason Rumney
2008-02-22 17:19   ` Dave Love
2008-02-23  0:41     ` jidanni

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.