From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: "Warning: `save-excursion' defeated by `set-buffer'" madness Date: Mon, 15 Feb 2010 13:56:56 -0800 Message-ID: <47A31A2B358F4F34B980D9EDC9672B18@us.oracle.com> References: <20100212204057.GG27521@headley> <20100214001755.GA2289@headley> <20100215111948.GB2289@headley><20100215155054.GC2289@headley> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1266271146 21393 80.91.229.12 (15 Feb 2010 21:59:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Feb 2010 21:59:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'Stefan Monnier'" , "'Barry Fishman'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 15 22:59:03 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nh8y7-0003K5-0x for ged-emacs-devel@m.gmane.org; Mon, 15 Feb 2010 22:59:03 +0100 Original-Received: from localhost ([127.0.0.1]:35575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh8y6-0005k1-IK for ged-emacs-devel@m.gmane.org; Mon, 15 Feb 2010 16:59:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nh8xV-0005Kk-LZ for emacs-devel@gnu.org; Mon, 15 Feb 2010 16:58:25 -0500 Original-Received: from [140.186.70.92] (port=58407 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh8xU-0005JV-RT for emacs-devel@gnu.org; Mon, 15 Feb 2010 16:58:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nh8xU-0007eo-Ba for emacs-devel@gnu.org; Mon, 15 Feb 2010 16:58:24 -0500 Original-Received: from rcsinet11.oracle.com ([148.87.113.123]:58446) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nh8xU-0007ej-4O for emacs-devel@gnu.org; Mon, 15 Feb 2010 16:58:24 -0500 Original-Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet11.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o1FLwFwK022350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 15 Feb 2010 21:58:17 GMT Original-Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o1FFFIcm013262; Mon, 15 Feb 2010 21:58:14 GMT Original-Received: from abhmt015.oracle.com by acsmt355.oracle.com with ESMTP id 28894601266271017; Mon, 15 Feb 2010 13:56:57 -0800 Original-Received: from dradamslap1 (/130.35.179.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 15 Feb 2010 13:56:55 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcqueiOZT6+JQlxeTHaFZDOyw2EsHQADHx5A X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4B79C377.001C:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121134 Archived-At: > Good, so the code that triggers the warning is in bbdb-com.el. > But the code that runs the byte-compiler (and hence causes those > harmless/informative warnings to turn into annoying windows > popping up) is in advice.el. > > I've just installed the patch below which should fix your problem. I would have thought that you would consider this annoyance to be a feature, drawing attention as it does so well to code that you consider worth warning about. ;-) So now, to suppress this one annoyance, you've removed all byte-compiler warnings for byte-compiling advice. I don't necessarily disagree, but are you sure that's TRT? Should this perhaps be configurable by users of advice (e.g. defadvice)? (Dunno.)