From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: Re: lisp/mail/rmail.el rmail-highlight definition Date: Thu, 31 Jan 2008 11:46:36 +0100 Message-ID: <47A1A70C.5070503@gmx.at> References: <20080130205851.0E8487B64@not-invented-here.oucs.ox.ac.uk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1201776427 12836 80.91.229.12 (31 Jan 2008 10:47:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jan 2008 10:47:07 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: pod Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 31 11:47:28 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JKWws-0000wA-CL for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Jan 2008 11:47:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JKWwR-0001pl-1N for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Jan 2008 05:46:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JKWuV-0000o5-7r for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2008 05:44:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JKWuT-0000nG-AP for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2008 05:44:46 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JKWuS-0000n9-NZ for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2008 05:44:44 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JKWuS-0008FA-KB for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2008 05:44:44 -0500 Original-Received: (qmail invoked by alias); 31 Jan 2008 10:44:42 -0000 Original-Received: from N819P013.adsl.highway.telekom.at (EHLO [62.47.46.77]) [62.47.46.77] by mail.gmx.net (mp008) with SMTP; 31 Jan 2008 11:44:42 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/aWzNbwQraWxLf0YQgUtOEirS5X9LC1JuF+lu2PN ztNVNeCqWQdeKV User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <20080130205851.0E8487B64@not-invented-here.oucs.ox.ac.uk> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17438 Archived-At: > I don't think the definition for the rmail-highlight face in emacs 22.1 is > correct. > > The face properties shown by M-x describe-face RET rmail-highlight are all > unspecified and indeed M-x list-faces-display shows the rmail-highlight > faces as completely plain whereas the highlight face has a darkolivegreen > (according to M-x describe-face RET highlight) background. > > The rmail-highlight face definition appears to be the same in CVS > > > > as it is in the lisp/mail/rmail.el from the distributed emacs 22.1 > tarball, namely: > > (defface rmail-highlight > '((t :default highlight)) > "Face to use for highlighting the most important header fields." > :group 'rmail-headers > :version "22.1") > > I think the intent is to derive a face from the highlight face, however > the value used above appears to be incorrect on two counts given the > description from M-x describe-function defface; there is no :default ATTR > and ATTS should be (ATTR VALUE ATTR VALUE ...). > > I believe the correct value to assign is ((t (:inherit hightlight))). > Indeed if I assign this using > > (custom-set-faces '(rmail-highlight ((t (:inherit highlight))))) > > I observe the content of From: and Subject: fields in my rmail buffers in > a face indistinguishable from the highlight face (i.e. with a > darkolivegreen background) whereas without this setting they appear in > what looks like the default face. > > Thank you for your time. Thank you very much for your precise report. I've installed the fix you suggested in the Emacs 22.2 branch. It should soon get merged into the trunk.