all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: pod <pod@herald.ox.ac.uk>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: lisp/mail/rmail.el rmail-highlight definition
Date: Thu, 31 Jan 2008 11:46:36 +0100	[thread overview]
Message-ID: <47A1A70C.5070503@gmx.at> (raw)
In-Reply-To: <20080130205851.0E8487B64@not-invented-here.oucs.ox.ac.uk>

> I don't think the definition for the rmail-highlight face in emacs 22.1 is
> correct.
> 
> The face properties shown by M-x describe-face RET rmail-highlight are all
> unspecified and indeed M-x list-faces-display shows the rmail-highlight
> faces as completely plain whereas the highlight face has a darkolivegreen
> (according to M-x describe-face RET highlight) background.
> 
> The rmail-highlight face definition appears to be the same in CVS
> 
> <http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lisp/mail/rmail.el?revision=1.445&view=markup>
> 
> as it is in the lisp/mail/rmail.el from the distributed emacs 22.1
> tarball, namely:
> 
>     (defface rmail-highlight
>       '((t :default highlight))
>       "Face to use for highlighting the most important header fields."
>       :group 'rmail-headers
>       :version "22.1")
> 
> I think the intent is to derive a face from the highlight face, however
> the value used above appears to be incorrect on two counts given the
> description from M-x describe-function defface; there is no :default ATTR
> and ATTS should be (ATTR VALUE ATTR VALUE ...).
> 
> I believe the correct value to assign is ((t (:inherit hightlight))).
> Indeed if I assign this using
> 
> (custom-set-faces '(rmail-highlight ((t (:inherit highlight)))))
> 
> I observe the content of From: and Subject: fields in my rmail buffers in
> a face indistinguishable from the highlight face (i.e. with a
> darkolivegreen background) whereas without this setting they appear in
> what looks like the default face.
> 
> Thank you for your time.

Thank you very much for your precise report.  I've installed the fix you
suggested in the Emacs 22.2 branch.  It should soon get merged into the
trunk.





      reply	other threads:[~2008-01-31 10:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 20:58 lisp/mail/rmail.el rmail-highlight definition pod
2008-01-31 10:46 ` martin rudalics [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A1A70C.5070503@gmx.at \
    --to=rudalics@gmx.at \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=pod@herald.ox.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.