Emacs CVS, ispell-change-dictionary etc...

Emacs CVS, ispell-change-dictionary etc...

[Angelo Graziosi]

I have noted that when for a buffer flyspell-mode is enable, then this 
is saved in .emacs.desktop so the next time one starts Emacs the buffer 
is reloaded with that mode enabled.

But if one also change the default dictionary
(M-x ispell-change-dictionary), the new dictionary is not saved for that 
buffer in .emacs.desktop!

Shouldn't it be saved?

My opinion is that when flyspell-mode is enabled also the current 
dictionary should be saved in the desktop file. But this is only my 
opinion and sorry for the noise.


Cheers,
    Angelo.

Re: Emacs CVS, ispell-change-dictionary etc...

[Richard Stallman]

Would someone please DTRT and then ack?

Message-ID: <4798727D.1020107@alice.it>
Date: Thu, 24 Jan 2008 12:11:57 +0100
From: Angelo Graziosi <angelo.graziosi@alice.it>
MIME-Version: 1.0
To: emacs-devel@gnu.org
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Subject: Emacs CVS, ispell-change-dictionary etc...

I have noted that when for a buffer flyspell-mode is enable, then this 
is saved in .emacs.desktop so the next time one starts Emacs the buffer 
is reloaded with that mode enabled.

But if one also change the default dictionary
(M-x ispell-change-dictionary), the new dictionary is not saved for that 
buffer in .emacs.desktop!

Shouldn't it be saved?

My opinion is that when flyspell-mode is enabled also the current 
dictionary should be saved in the desktop file. But this is only my 
opinion and sorry for the noise.


Cheers,
    Angelo.


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Emacs CVS, ispell-change-dictionary etc...

[Glenn Morris]

> Date: Thu, 24 Jan 2008 12:11:57 +0100
> From: Angelo Graziosi <angelo.graziosi@alice.it>
> To: emacs-devel@gnu.org
> Subject: Emacs CVS, ispell-change-dictionary etc...
>
> I have noted that when for a buffer flyspell-mode is enable, then this 
> is saved in .emacs.desktop so the next time one starts Emacs the buffer 
> is reloaded with that mode enabled.
>
> But if one also change the default dictionary
> (M-x ispell-change-dictionary), the new dictionary is not saved for that 
> buffer in .emacs.desktop!

The list of local variables saved and restored by desktop is
customizable through `desktop-locals-to-save'. You probably want to
add `ispell-local-dictionary' or something similar to this list. It
can't contain everything by default.

Re: Emacs CVS, ispell-change-dictionary etc...

[Angelo Graziosi]

Glenn Morris wrote:
>> Date: Thu, 24 Jan 2008 12:11:57 +0100
>> From: Angelo Graziosi <angelo.graziosi@alice.it>
>> To: emacs-devel@gnu.org
>> Subject: Emacs CVS, ispell-change-dictionary etc...
>>
>> I have noted that when for a buffer flyspell-mode is enable, then this 
>> is saved in .emacs.desktop so the next time one starts Emacs the buffer 
>> is reloaded with that mode enabled.
>>
>> But if one also change the default dictionary
>> (M-x ispell-change-dictionary), the new dictionary is not saved for that 
>> buffer in .emacs.desktop!
> 
> The list of local variables saved and restored by desktop is
> customizable through `desktop-locals-to-save'. You probably want to
> add `ispell-local-dictionary' or something similar to this list. It
> can't contain everything by default.

I would that if buffer-A is spelled with italian dict., buffer-B with 
english dict., buffer-C..., then the same should happen when these 
buffers are reloaded (if flyspell is saved).

So which variables should I add to desktop-locals-to-save (a little 
example?)?

In any case, I remains in my opinion: If the logic is to save, by 
default, the flyspell-mode for a buffer, also the dictionary with which 
the buffer is spelled should be saved. If not then also flyspell should 
not, by default!


Cheers,
    Angelo.


---
Facesti come quei che va di notte,
che porta il lume dietro e se' non giova,
ma dopo se' fa le persone dotte.
---
                   DANTE, Purgatorio, xxii 67-69

Re: Emacs CVS, ispell-change-dictionary etc...

[Stefan Monnier]

>> The list of local variables saved and restored by desktop is
>> customizable through `desktop-locals-to-save'. You probably want to
>> add `ispell-local-dictionary' or something similar to this list. It
>> can't contain everything by default.

Could ispell.el add ispell-local-dictionary to desktop-locals-to-save?


        Stefan

Re: Emacs CVS, ispell-change-dictionary etc...

[Glenn Morris]

Stefan Monnier wrote:

> Could ispell.el add ispell-local-dictionary to desktop-locals-to-save?

It could, but I don't see what makes this different to any other local
variable, nor why one wouldn't be better off with this in a file local
variables section.

Re: Emacs CVS, ispell-change-dictionary etc...

[Angelo Graziosi]

Glenn Morris wrote:
> Stefan Monnier wrote:
> 
>> Could ispell.el add ispell-local-dictionary to desktop-locals-to-save?
> 
> It could, but I don't see what makes this different to any other local
> variable, nor why one wouldn't be better off with this in a file local
> variables section.

I have add to my .emacs:

(setq desktop-locals-to-save
       (cons 'ispell-local-dictionary desktop-locals-to-save))

Right?

But the problem I posed is on Principle!

If for a buffer the flyspell-mode is saved in the .emacs.desktop file 
then the logic asks that also the dictionary with which the buffer is 
spelled SHOULD be saved!

Why NOT?

Why these two things should be separate?


Cheers,
    Angelo.

Re: Emacs CVS, ispell-change-dictionary etc...

[martin rudalics]

 >>Could ispell.el add ispell-local-dictionary to desktop-locals-to-save?
 >
 > It could, but I don't see what makes this different to any other local
 > variable, nor why one wouldn't be better off with this in a file local
 > variables section.

Agreed.  We could add flyspell/ispell to `desktop-minor-mode-table' and
`desktop-minor-mode-handlers' with appropriate functions to save and
restore values like `ispell-local-dictionary'.  But I don't understand
neither Gerd's comments nor his implementation of this yet.

BTW does anyone know why some minor modes like `overwrite-mode' are in
`desktop-locals-to-save' and others like `transient-mark-mode' and
`visible-mode' are not?

Re: Emacs CVS, ispell-change-dictionary etc...

[Glenn Morris]

Angelo Graziosi wrote:

> If for a buffer the flyspell-mode is saved in the .emacs.desktop file 
> then the logic asks that also the dictionary with which the buffer is 
> spelled SHOULD be saved!
>
> Why NOT?
>
> Why these two things should be separate?

Because desktop has no explicit code for flyspell, it simply saves and
restores all the active minor modes.

Re: Emacs CVS, ispell-change-dictionary etc...

[Richard Stallman]

    Because desktop has no explicit code for flyspell, it simply saves and
    restores all the active minor modes.

Someone made the point that if and when desktop records that flyspell
mode is on, it would be quite useful to also record which dictionary
it uses.  I agree -- that would be more convenient for users.

If that requires some special code in desktop.el for the sake of
flyspell, I think it's worth it.