From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; Deleting files in wdired does not work Date: Sat, 26 Jan 2008 18:27:42 +0100 Message-ID: <479B6D8E.3050109@gmx.at> References: <60c603510801202141p7e4fdcfcmddf4d81b330a9715@mail.gmail.com> <4799915E.9090400@gmx.at> <60c603510801250216r7f62a876s37a86719d46d7633@mail.gmail.com> <4799E161.4020404@gmx.at> <60c603510801251443s514ab02cy2bcbf01754eaeac6@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1201368402 29142 80.91.229.12 (26 Jan 2008 17:26:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Jan 2008 17:26:42 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: Phil Sung Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 26 18:27:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JIonw-0001tf-KA for ged-emacs-devel@m.gmane.org; Sat, 26 Jan 2008 18:26:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIonW-0006sx-33 for ged-emacs-devel@m.gmane.org; Sat, 26 Jan 2008 12:26:30 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIon5-0006ZN-RS for emacs-devel@gnu.org; Sat, 26 Jan 2008 12:26:03 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIon1-0006XW-Nc for emacs-devel@gnu.org; Sat, 26 Jan 2008 12:26:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIon1-0006XQ-If for emacs-devel@gnu.org; Sat, 26 Jan 2008 12:25:59 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JIon1-000477-Eg for emacs-devel@gnu.org; Sat, 26 Jan 2008 12:25:59 -0500 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JIon1-0006Qd-4n for emacs-pretest-bug@gnu.org; Sat, 26 Jan 2008 12:25:59 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JIomx-00045p-RK for emacs-pretest-bug@gnu.org; Sat, 26 Jan 2008 12:25:58 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JIomx-00045I-BC for emacs-pretest-bug@gnu.org; Sat, 26 Jan 2008 12:25:55 -0500 Original-Received: (qmail invoked by alias); 26 Jan 2008 17:25:53 -0000 Original-Received: from M3183P015.adsl.highway.telekom.at (EHLO [88.117.45.207]) [88.117.45.207] by mail.gmx.net (mp006) with SMTP; 26 Jan 2008 18:25:53 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18pjTwPNIwpNfCLfE3lQ9JSukivHOIenEiLRCHy6r a7avRMeblHd3EE User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <60c603510801251443s514ab02cy2bcbf01754eaeac6@mail.gmail.com> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87587 gmane.emacs.pretest.bugs:20770 Archived-At: > After re-reading your previous diagnosis, I think there is a shorter > fix. Searching for 'end-name starting from beg instead of (1+ beg) > finds the end of filename correctly whether the filename is empty or > not. > > Once wdired-get-filename is fixed, wdired-finish-edit actually needs > no changes, because (wdired-get-filename) does return nil when the > filename is empty. > > * wdired.el (wdired-get-filename): Change `(1+ beg)' to `beg' so > that the filename end is found even when the filename is empty. > Fixes error and spurious newlines when marking files for deletion. Checked into Emacs 22 branch and the trunk. Thanks again.