From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; Deleting files in wdired does not work Date: Fri, 25 Jan 2008 14:17:21 +0100 Message-ID: <4799E161.4020404@gmx.at> References: <60c603510801202141p7e4fdcfcmddf4d81b330a9715@mail.gmail.com> <4799915E.9090400@gmx.at> <60c603510801250216r7f62a876s37a86719d46d7633@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1201267008 30849 80.91.229.12 (25 Jan 2008 13:16:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Jan 2008 13:16:48 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: Phil Sung Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 25 14:17:07 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JIOQc-00005R-NU for ged-emacs-devel@m.gmane.org; Fri, 25 Jan 2008 14:17:07 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIOQC-0007DJ-8y for ged-emacs-devel@m.gmane.org; Fri, 25 Jan 2008 08:16:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIOQ7-0007D0-12 for emacs-devel@gnu.org; Fri, 25 Jan 2008 08:16:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIOQ4-0007Cf-HG for emacs-devel@gnu.org; Fri, 25 Jan 2008 08:16:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIOQ4-0007Cc-DO for emacs-devel@gnu.org; Fri, 25 Jan 2008 08:16:32 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JIOQ4-0003j3-AK for emacs-devel@gnu.org; Fri, 25 Jan 2008 08:16:32 -0500 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JIOQ2-0002Dy-A6 for emacs-pretest-bug@gnu.org; Fri, 25 Jan 2008 08:16:30 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JIOPz-0003hk-4F for emacs-pretest-bug@gnu.org; Fri, 25 Jan 2008 08:16:30 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JIOPy-0003hQ-LG for emacs-pretest-bug@gnu.org; Fri, 25 Jan 2008 08:16:27 -0500 Original-Received: (qmail invoked by alias); 25 Jan 2008 13:16:25 -0000 Original-Received: from N873P024.adsl.highway.telekom.at (EHLO [62.47.53.24]) [62.47.53.24] by mail.gmx.net (mp001) with SMTP; 25 Jan 2008 14:16:25 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18veVVd3HUvuXfCV8Yn55QQCjbn5lG5Hj9ACIMZD1 AQVy6GgCmH969m User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <60c603510801250216r7f62a876s37a86719d46d7633@mail.gmail.com> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87491 gmane.emacs.pretest.bugs:20748 Archived-At: > The following works for me, assuming (wdired-get-filename t) > ought to return "" rather than nil on a deleted filename: Looks good, thank you. I think this ought to return "" here because nil should be reserved for `wdired-get-filename' was not able to figure out the user's intentions from the text it found there. And marking a file for deletion is a fairly dangerous undertaking. If no one objects I'll install this in Emacs 22.2 in a couple of days. Meanwhile you could do two things: - Use (string-equal (wdired-get-filename t) "") instead of (zerop (length (wdired-get-filename t))) because the latter will return t when `wdired-get-filename' returns nil. - Add a couple of comments documenting what was wrong and what you have done to fix it. Thanks again.