all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* face names in blank-mode.el
@ 2008-01-19 16:40 Dan Nicolaescu
  2008-01-20  4:06 ` Glenn Morris
  2008-01-21  4:17 ` Vinicius Jose Latorre
  0 siblings, 2 replies; 7+ messages in thread
From: Dan Nicolaescu @ 2008-01-19 16:40 UTC (permalink / raw)
  To: emacs-devel


Isn't using the -face suffix for faces deprecated now?
The new package blank-mode.el that was very recently added does it for
all of its faces:

$ grep defface blank-mode.el
;; indicating defface byte-compilation warnings.
(defface blank-space-face
(defface blank-hspace-face              ; 'nobreak-space
(defface blank-tab-face
(defface blank-newline-face
(defface blank-trailing-face            ; 'trailing-whitespace
(defface blank-line-face
(defface blank-space-before-tab-face

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: face names in blank-mode.el
  2008-01-19 16:40 face names in blank-mode.el Dan Nicolaescu
@ 2008-01-20  4:06 ` Glenn Morris
  2008-01-21  4:17 ` Vinicius Jose Latorre
  1 sibling, 0 replies; 7+ messages in thread
From: Glenn Morris @ 2008-01-20  4:06 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel

Dan Nicolaescu wrote:

> Isn't using the -face suffix for faces deprecated now?

Not deprecated, just plain wrong.

See display.texi "Defining Faces":

"it should not end in @samp{-face} (that would be redundant)."

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: face names in blank-mode.el
  2008-01-21  4:17 ` Vinicius Jose Latorre
@ 2008-01-21  3:21   ` Miles Bader
  2008-01-21  4:36     ` Vinicius Jose Latorre
  0 siblings, 1 reply; 7+ messages in thread
From: Miles Bader @ 2008-01-21  3:21 UTC (permalink / raw)
  To: Vinicius Jose Latorre; +Cc: Dan Nicolaescu, emacs-devel

Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>> $ grep defface blank-mode.el
>
> Other packages also have "-face" suffix: font-lock, planner.

font-lock-* faces keep the suffix for histerical reasons; any others are
bugs.

-Miles

-- 
Bacchus, n. A convenient deity invented by the ancients as an excuse for
getting drunk.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: face names in blank-mode.el
  2008-01-21  4:36     ` Vinicius Jose Latorre
@ 2008-01-21  3:39       ` Miles Bader
  2008-01-21 13:55       ` Vinicius Jose Latorre
  1 sibling, 0 replies; 7+ messages in thread
From: Miles Bader @ 2008-01-21  3:39 UTC (permalink / raw)
  To: Vinicius Jose Latorre; +Cc: Dan Nicolaescu, emacs-devel

Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>> font-lock-* faces keep the suffix for histerical reasons; any others are
>> bugs.
>
> Maybe you mean "historical", isn't it?

Yeah, well, both really :-)

-Miles

-- 
Helpmate, n. A wife, or bitter half.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: face names in blank-mode.el
  2008-01-19 16:40 face names in blank-mode.el Dan Nicolaescu
  2008-01-20  4:06 ` Glenn Morris
@ 2008-01-21  4:17 ` Vinicius Jose Latorre
  2008-01-21  3:21   ` Miles Bader
  1 sibling, 1 reply; 7+ messages in thread
From: Vinicius Jose Latorre @ 2008-01-21  4:17 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel


> Isn't using the -face suffix for faces deprecated now?
> The new package blank-mode.el that was very recently added does it for
> all of its faces:
>
> $ grep defface blank-mode.el
> ;; indicating defface byte-compilation warnings.
> (defface blank-space-face
> (defface blank-hspace-face              ; 'nobreak-space
> (defface blank-tab-face
> (defface blank-newline-face
> (defface blank-trailing-face            ; 'trailing-whitespace
> (defface blank-line-face
> (defface blank-space-before-tab-face
>   

Other packages also have "-face" suffix: font-lock, planner.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: face names in blank-mode.el
  2008-01-21  3:21   ` Miles Bader
@ 2008-01-21  4:36     ` Vinicius Jose Latorre
  2008-01-21  3:39       ` Miles Bader
  2008-01-21 13:55       ` Vinicius Jose Latorre
  0 siblings, 2 replies; 7+ messages in thread
From: Vinicius Jose Latorre @ 2008-01-21  4:36 UTC (permalink / raw)
  To: Miles Bader; +Cc: Dan Nicolaescu, emacs-devel


>>> $ grep defface blank-mode.el
>>>       
>> Other packages also have "-face" suffix: font-lock, planner.
>>     
>
> font-lock-* faces keep the suffix for histerical reasons; any others are
> bugs.
>   

Maybe you mean "historical", isn't it?

Ok, I'll eliminate -face suffix tomorrow.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: face names in blank-mode.el
  2008-01-21  4:36     ` Vinicius Jose Latorre
  2008-01-21  3:39       ` Miles Bader
@ 2008-01-21 13:55       ` Vinicius Jose Latorre
  1 sibling, 0 replies; 7+ messages in thread
From: Vinicius Jose Latorre @ 2008-01-21 13:55 UTC (permalink / raw)
  To: Miles Bader; +Cc: Dan Nicolaescu, emacs-devel


>>>> $ grep defface blank-mode.el
>>>>       
>>> Other packages also have "-face" suffix: font-lock, planner.  
>>
>> font-lock-* faces keep the suffix for histerical reasons; any others are
>> bugs.   
>
> Maybe you mean "historical", isn't it?
>
> Ok, I'll eliminate -face suffix tomorrow.

"-face" suffix just eliminated in CVS trunk and emacs 22 branch.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2008-01-21 13:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-19 16:40 face names in blank-mode.el Dan Nicolaescu
2008-01-20  4:06 ` Glenn Morris
2008-01-21  4:17 ` Vinicius Jose Latorre
2008-01-21  3:21   ` Miles Bader
2008-01-21  4:36     ` Vinicius Jose Latorre
2008-01-21  3:39       ` Miles Bader
2008-01-21 13:55       ` Vinicius Jose Latorre

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.