From: martin rudalics <rudalics@gmx.at>
To: rms@gnu.org
Cc: jan.h.d@swipnet.se, emacs-devel@gnu.org
Subject: Re: [Fwd: Frame Height Different for Default Frame and Additional Frames]
Date: Fri, 28 Dec 2007 21:06:46 +0100 [thread overview]
Message-ID: <47755756.20601@gmx.at> (raw)
In-Reply-To: <E1J8Fh6-0002VJ-LK@fencepost.gnu.org>
> Perhaps I have misunderstood the nature of the problem. I thought the
> problem was that the height in default-frame-alist was being ignored
> entirely for the first frame, from these words:
>
> > Yes they do. It looks like default-frame-alist is ignored for the first frame.
>
> My experience is that it is not ignored.
>
> You're now talking about a completely different problem:
Your experience and mine are identic but the problem goes as follows:
The OP observed that the height of the initial (first) frame differs
from that of additional frames. We found out that their heights differ
by the height of the toolbar, that is, additional frames are by the
height of the toolbar higher than the initial (first) frame. So if you
say that the initial frame is good, the bug must be with the additional
frames and _not_ with the initial one. Hence we've been discussing the
problem with different premises.
> Commenting out the following stretch from frame.c fixes the bug for me.
>
> /* This used to be done _before_ calling x_figure_window_size, but
> since the height is reset here, this was really a no-op. I
> assume that moving it here does what Gerd intended (although he
> no longer can remember what that was... ++KFS, 2003-03-25. */
> ....
>
> I think that change causes another bug. The height in lines of an
> Emacs frame is not supposed to include the tool bar. If you create a
> frame and specify 40 lines, you should get 40 lines of text, plus a
> tool bar.
As Jan said this code is executed exclusively with the native toolbar,
hence we would have to judge whether not executing that code DTRT for
toolkit scrollbars. With the native toolbar, this code is not executed
for the initial frame (at least not here), hence we would have to judge
whether not executing that code for the initial frame does TRT. Here,
this code gets executed only for additional frames and iff I have
toolbars enabled.
> The size of the initial frame seems correct because initial frames get
> the same height regardless of whether they have a tool-bar or not (if
> they didn't we'd probably have another bug).
>
> Could you explain that precisely? Perhaps that special feature for -g
> and the initial frame needs to be implemented in a different place.
Please recall that I didn't use -g to produce the bug, just a
single-line .emacs containing
(add-to-list 'default-frame-alist '(height . 37))
What I wanted to express above is that my initial Emacs frame has the
same height regardless of whether I have toolbars enabled or not. Also,
the heights of my frames never change when I switch toolbars on and off.
next prev parent reply other threads:[~2007-12-28 20:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 16:56 Frame Height Different for Default Frame and Additional Frames Rocco Pigneri
2007-10-02 7:52 ` martin rudalics
[not found] ` <E1Iewxc-0004U8-CC@fencepost.gnu.org>
2007-10-08 21:12 ` [Fwd: Frame Height Different for Default Frame and Additional Frames] martin rudalics
2007-10-09 20:02 ` Richard Stallman
2007-10-09 21:25 ` martin rudalics
2007-10-10 5:55 ` Jan Djärv
2007-10-10 6:51 ` martin rudalics
2007-10-10 7:39 ` Jan Djärv
2007-10-10 7:50 ` Jason Rumney
2007-10-10 20:41 ` martin rudalics
2007-10-11 6:15 ` Jan Djärv
2007-10-11 8:52 ` martin rudalics
2007-10-11 14:01 ` Stefan Monnier
2007-10-14 16:29 ` Richard Stallman
2007-10-11 5:19 ` Richard Stallman
2007-10-11 8:52 ` martin rudalics
2007-10-11 18:03 ` Jan Djärv
2007-12-25 17:17 ` Richard Stallman
2007-12-27 19:10 ` martin rudalics
2007-12-28 13:56 ` Richard Stallman
2007-12-28 20:06 ` martin rudalics [this message]
2007-12-28 23:09 ` Robert J. Chassell
2007-12-28 23:51 ` martin rudalics
2008-01-05 11:22 ` Jan Djärv
2008-01-05 13:08 ` martin rudalics
2008-01-05 17:33 ` Jan Djärv
2008-01-05 18:08 ` Drew Adams
2008-01-05 22:42 ` Robert J. Chassell
2008-01-05 23:00 ` Jan Djärv
2008-01-06 8:08 ` Richard Stallman
2008-01-06 20:19 ` Stefan Monnier
2008-01-06 20:45 ` [Fwd: Frame Height Different for Default Frame and AdditionalFrames] Drew Adams
2007-10-10 21:03 ` [Fwd: Frame Height Different for Default Frame and Additional Frames] Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47755756.20601@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.