all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: Sacha Chua <sacha@free.net.ph>
Cc: Ryan Yeske <rcyeske@gmail.com>, emacs-devel@gnu.org
Subject: Re: remember-region should be autoloaded
Date: Wed, 19 Dec 2007 12:15:23 +0100	[thread overview]
Message-ID: <4768FD4B.2060809@gmail.com> (raw)
In-Reply-To: <87mys73r3l.fsf@tarn.lan>

Ryan Yeske wrote:
> I usually use M-x remember-region to record notes from text in my emacs
> buffers.
> 
> 
> 2007-12-19  Ryan Yeske  <rcyeske@gmail.com>
> 
> 	* textmodes/remember.el (remember-region): Add autoload cookie.
> 
> 
> diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
> index 81be7ac..01d1954 100644
> --- a/lisp/textmodes/remember.el
> +++ b/lisp/textmodes/remember.el
> @@ -419,6 +419,7 @@ Subject: %s\n\n"
>                (when remember-save-after-remembering (save-buffer))))
>          (append-to-file (point-min) (point-max) remember-data-file)))))
>  
> +;;;###autoload
>  (defun remember-region (&optional beg end)
>    "Remember the data from BEG to END.
>  It is called from within the *Remember* buffer to save the text
> 
> 
> Diffs between working revision and workfile end here.

In my version of remember.el remember-region is already autoloaded, but 
it looks to me from the doc string like it should not be that since it 
is meant to be called from the *Remember* buffer.

However there is a small bug in remember in the way it handles the 
region. Beside that it would be nice if it used the region when it is 
visible. Something like this in the beginning of remember:

(defun remember (&optional initial)
   "Remember an arbitrary piece of data.
With a prefix or a visible region, uses the region as INITIAL."
   (interactive
    (list (when (or current-prefix-arg
                    (and mark-active
                         transient-mark-mode))
            (buffer-substring-noproperties
             (region-beginning) (region-end)))))

  reply	other threads:[~2007-12-19 11:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-19 10:40 remember-region should be autoloaded Ryan Yeske
2007-12-19 11:15 ` Lennart Borgman (gmail) [this message]
2007-12-19 12:47   ` Leo
2008-01-08  1:34     ` Michael Olson
2007-12-23 17:51   ` Juri Linkov
2007-12-23 18:04     ` Lennart Borgman (gmail)
2007-12-24 13:31     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4768FD4B.2060809@gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=rcyeske@gmail.com \
    --cc=sacha@free.net.ph \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.