From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: vc-revision-other-window problem Date: Mon, 17 Dec 2007 08:57:35 +0100 Message-ID: <47662BEF.80203@gmx.at> References: <20071217010646.GA56945@orion.lan> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1197879941 26691 80.91.229.12 (17 Dec 2007 08:25:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2007 08:25:41 +0000 (UTC) Cc: emacs-devel@gnu.org To: Emanuele Giaquinta Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 17 09:25:52 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J4BIN-0003zn-Fw for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2007 09:25:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J4BI3-0007ho-Dc for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2007 03:25:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J4BH9-00074R-Vo for emacs-devel@gnu.org; Mon, 17 Dec 2007 03:24:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J4BH7-00072H-TY for emacs-devel@gnu.org; Mon, 17 Dec 2007 03:24:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J4BH7-000722-NL for emacs-devel@gnu.org; Mon, 17 Dec 2007 03:24:33 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1J4BH6-0005iv-7X for emacs-devel@gnu.org; Mon, 17 Dec 2007 03:24:33 -0500 Original-Received: (qmail invoked by alias); 17 Dec 2007 07:57:49 -0000 Original-Received: from N743P017.adsl.highway.telekom.at (EHLO [62.47.36.209]) [62.47.36.209] by mail.gmx.net (mp002) with SMTP; 17 Dec 2007 08:57:49 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18YUW0pwA0YJS1G+mF7Q8yCRBPGkacgFYNKQbypVT UFduCXPxwpMRwA User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <20071217010646.GA56945@orion.lan> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85203 Archived-At: > in latest cvs vc-revision-other-window hangs in vc-ensure-vc-buffer > when called for the second time. The problem seems to be the following > code in vc-ensure-vc-buffer > > (while vc-parent-buffer > (set-buffer vc-parent-buffer)) > > the first time it is fine because vc-parent-buffer is nil, but, since > vc-revision-other-window calls vc-find-revision which sets > vc-parent-buffer, the second time vc-parent-buffer will have a non nil > value. Hope the diagnosis is correct. Does it work with the attached patch?