From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: assertion failed: c == event->code Date: Mon, 17 Dec 2007 01:52:18 +0000 Message-ID: <4765D652.6040405@gnu.org> References: <47613EC3.7020004@gnu.org> <47624334.109@gnu.org> <476275B1.7040202@gnu.org> <47658F6E.4020800@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1197856411 11399 80.91.229.12 (17 Dec 2007 01:53:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2007 01:53:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 17 02:53:42 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J45Ak-0002j5-8h for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2007 02:53:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J45AD-0007oZ-GA for ged-emacs-devel@m.gmane.org; Sun, 16 Dec 2007 20:53:01 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J45AA-0007oP-Io for emacs-devel@gnu.org; Sun, 16 Dec 2007 20:52:58 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J45A5-0007nv-45 for emacs-devel@gnu.org; Sun, 16 Dec 2007 20:52:58 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J45A5-0007ns-0d for emacs-devel@gnu.org; Sun, 16 Dec 2007 20:52:53 -0500 Original-Received: from mk-outboundfilter-4-a-1.mail.uk.tiscali.com ([212.74.114.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J459x-0005AR-B0 for emacs-devel@gnu.org; Sun, 16 Dec 2007 20:52:52 -0500 Original-X-Trace: 1173359/mk-outboundfilter-2.mail.uk.tiscali.com/F2S/$ACCEPTED/freedom2Surf-customers/83.67.23.108 X-SBRS: None X-RemoteIP: 83.67.23.108 X-IP-MAIL-FROM: jasonr@gnu.org X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAMNlZUdTQxds/2dsb2JhbAAIkU+XCA Original-Received: from i-83-67-23-108.freedom2surf.net (HELO [192.168.249.28]) ([83.67.23.108]) by smtp.f2s.tiscali.co.uk with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Dec 2007 01:52:22 +0000 User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) In-Reply-To: <47658F6E.4020800@gnu.org> X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85198 Archived-At: Jason Rumney wrote: > Juanma Barranquero wrote: > >> Unless someone opposes, I'm gonna install this change. >> >> This is the best of both worlds: the C-ñ, C-ç, etc. keystrokes do not >> trigger the assertion, and they are not ignored by Emacs. >> >> > Does it give correct results? The reason I left keys > 0xff out is that > the code to handle non-ASCII keys does not properly handle such values. > If there is a ctrl bit to filter out, then lets filter it out. > The problem was caused by a signed/unsigned mismatch where the WM_CHAR message was created in w32fns.c. I've fixed it now, no need to check in your change.