From: Vinicius Jose Latorre <viniciusjl@ig.com.br>
To: martin rudalics <rudalics@gmx.at>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
"Richard M. Stallman" <rms@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Uninformative comment in files.el
Date: Tue, 11 Dec 2007 23:22:35 -0300 [thread overview]
Message-ID: <475F45EB.2070704@ig.com.br> (raw)
In-Reply-To: <475F0992.2030307@gmx.at>
martin rudalics wrote:
>>> Could whoever installed the following change:
>>>
>>> 2007-12-10 Yoni Rabkin Katzenell <yoni-r@actcom.com> (tiny
>>> change)
>>> * file.el (revert-buffer): Eliminate overlays and the mark.
>>>
>>> replace the comment "Reset the mark and remove all overlays" which just
>>> paraphrases the code, with a comment that actually explains why we
>>> want/need to do that?
>>>
>>
>>
>> This is not explained in etc/TODO file.
>>
>> The patch refers to this line in etc/TODO file:
>>
>> ** revert-buffer should eliminate overlays and the mark.
>>
>>
>> Does anyone know why this is necessary?
>
> I'm afraid the patch installed is overly simplistic. You can find out
> more by looking at the thread starting with
>
> http://lists.gnu.org/archive/html/emacs-devel/2005-11/msg01346.html
>
> For the moment I'd strongly propose to revert the change and study the
> problem in more depth.
Ok, I've read the thread. Indeed, the problem is not so simple.
I've just undone the patch in CVS trunk.
next prev parent reply other threads:[~2007-12-12 2:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 18:46 Uninformative comment in files.el Stefan Monnier
2007-12-11 20:55 ` Vinicius Jose Latorre
2007-12-11 22:05 ` martin rudalics
2007-12-12 2:22 ` Vinicius Jose Latorre [this message]
2007-12-12 6:31 ` Yoni Rabkin Katzenell
2007-12-12 9:17 ` martin rudalics
2007-12-12 14:22 ` Yoni Rabkin Katzenell
2007-12-12 12:28 ` Vinicius Jose Latorre
2007-12-12 15:20 ` Stefan Monnier
2007-12-12 15:41 ` Yoni Rabkin Katzenell
2007-12-13 16:51 ` Richard Stallman
2007-12-13 17:00 ` Stefan Monnier
2007-12-13 19:01 ` martin rudalics
2007-12-13 19:35 ` David Kastrup
2007-12-14 20:49 ` Richard Stallman
2007-12-14 20:49 ` Richard Stallman
2007-12-16 3:43 ` Stephen J. Turnbull
2007-12-17 8:24 ` Richard Stallman
[not found] ` <E1J2aRp-00010Y-QD@fencepost.gnu.org>
[not found] ` <476084A9.4010800@ig.com.br>
2007-12-14 10:10 ` Richard Stallman
2007-12-20 23:54 ` Stefan Monnier
2007-12-21 19:49 ` Richard Stallman
2007-12-23 0:57 ` Stefan Monnier
2007-12-12 22:52 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475F45EB.2070704@ig.com.br \
--to=viniciusjl@ig.com.br \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rms@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.