From: Jason Rumney <jasonr@gnu.org>
To: Dave Goel <deego3@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Fixing numerous `message' bugs..
Date: Mon, 10 Dec 2007 18:04:01 +0000 [thread overview]
Message-ID: <475D7F91.80503@gnu.org> (raw)
In-Reply-To: <87ir36o3as.fsf@marie.gnufans.net>
Dave Goel wrote:
> [...]
>
>
> I am a C newbie. I was playing around with editfns.c that would
> implement RMS's (message t ..) idea.. , and tried the attached patch.
> It seemed to compile fine. But, compiling via 'make bootstrap' always
> fails at the end with a segfault, as seen below. If I revert to the
> original editfns.c, 'make bootstrap' finishes all the way to the end.
> Any hints what I am doing wrong? Thanks.
>
You're returning 1, where a Lisp_Object is expected.
I'd refactor your changes to the following, to make it clearer what is
actually being changed (most of the diff you posted is whitespace
changes due to increased nesting):
if (NILP (args[0])
{
message (0);
return args[0];
}
+ else if (Fequal(args[0],Qt))
+ {
+ register Lisp_Object val;
+ Lisp_Object argb[2];
+ argb[0]=build_string("%s");
+ argb[1]=args[1];
+ val = Fformat (2, argb);
+ message3 (val, SBYTES (val), STRING_MULTIBYTE (val));
+ return 1;
+ }
else
{
register Lisp_Object val;
val = Fformat (nargs, args);
next prev parent reply other threads:[~2007-12-10 18:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 0:14 Fixing numerous `message' bugs D. Goel
2007-12-06 10:56 ` David Kastrup
2007-12-06 14:36 ` Dave Goel
2007-12-06 19:26 ` Glenn Morris
2007-12-06 19:34 ` Dave Goel
2007-12-06 20:21 ` Johan Bockgård
2007-12-07 5:28 ` Glenn Morris
2007-12-07 15:52 ` Dave Goel
2007-12-06 15:53 ` Stefan Monnier
2007-12-06 16:01 ` Dave Goel
2007-12-06 16:49 ` Stefan Monnier
2007-12-06 16:58 ` David Kastrup
2007-12-06 17:19 ` David Kastrup
2007-12-07 17:17 ` Richard Stallman
2007-12-07 17:37 ` David Kastrup
2007-12-07 17:17 ` Richard Stallman
2007-12-07 17:18 ` Richard Stallman
2007-12-07 17:24 ` David Kastrup
2007-12-07 18:00 ` Dave Goel
2007-12-07 18:38 ` Stefan Monnier
2007-12-08 0:56 ` Glenn Morris
2007-12-08 2:21 ` Stefan Monnier
2007-12-08 10:55 ` David Kastrup
2007-12-08 19:15 ` Richard Stallman
2007-12-10 17:41 ` Dave Goel
2007-12-10 18:04 ` Jason Rumney [this message]
2007-12-10 19:05 ` Dave Goel
2007-12-10 19:56 ` Andreas Schwab
2007-12-10 20:31 ` Dave Goel
2007-12-10 21:19 ` David Kastrup
2007-12-10 22:44 ` Dave Goel
2007-12-10 23:02 ` David Kastrup
2007-12-08 19:15 ` Richard Stallman
2007-12-07 17:18 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475D7F91.80503@gnu.org \
--to=jasonr@gnu.org \
--cc=deego3@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.