From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*] Date: Mon, 03 Dec 2007 09:36:03 +0000 Message-ID: <4753CE03.3030601@gnu.org> References: <4753AD13.9040400@swipnet.se> <4753CC43.1020107@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1196674648 21870 80.91.229.12 (3 Dec 2007 09:37:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Dec 2007 09:37:28 +0000 (UTC) Cc: rms@gnu.org, Drew Adams , emacs-devel@gnu.org To: =?ISO-8859-15?Q?Jan_Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 03 10:37:37 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iz7k5-0001X3-Jo for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2007 10:37:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iz7jp-0004qd-1f for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2007 04:37:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iz7jY-0004lD-Em for emacs-devel@gnu.org; Mon, 03 Dec 2007 04:37:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iz7jV-0004jw-OC for emacs-devel@gnu.org; Mon, 03 Dec 2007 04:36:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iz7jU-0004je-R1 for emacs-devel@gnu.org; Mon, 03 Dec 2007 04:36:57 -0500 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iz7jP-0001DB-09; Mon, 03 Dec 2007 04:36:51 -0500 Original-Received: from [192.168.249.28] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id E8B3750E32; Mon, 3 Dec 2007 09:36:49 +0000 (GMT) User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) In-Reply-To: <4753CC43.1020107@gnu.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84552 Archived-At: Jason Rumney wrote: > However, I think it is the documentation that needs fixing here to match > the documentation of read-file-name. > I propose the following change to make the documentation clearer for this variable: *** fns.c.~1.424.2.3.~ 2007-09-24 16:28:57.750000000 +0100 --- fns.c 2007-12-03 09:34:13.187500000 +0000 *************** *** 5827,5836 **** use_dialog_box = 1; DEFVAR_BOOL ("use-file-dialog", &use_file_dialog, ! doc: /* *Non-nil means mouse commands use a file dialog to ask for files. ! This applies to commands from menus and tool bar buttons. The value of ! `use-dialog-box' takes precedence over this variable, so a file dialog is only ! used if both `use-dialog-box' and this variable are non-nil. */); use_file_dialog = 1; defsubr (&Sidentity); --- 5827,5838 ---- use_dialog_box = 1; DEFVAR_BOOL ("use-file-dialog", &use_file_dialog, ! doc: /* *Non-nil means mouse commands use a file dialog to ask for ! files. This applies to commands from menus and tool bar buttons even ! when they are initiated from the keyboard. The value of ! `use-dialog-box' takes precedence over this variable, so a file dialog ! is only used if both `use-dialog-box' and this variable are ! non-nil. */); use_file_dialog = 1; defsubr (&Sidentity);