From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: invisible Date: Fri, 23 Nov 2007 15:25:19 +0100 Message-ID: <4746E2CF.4010604@gmx.at> References: <20040225.150142.12214540.kazu@iijlab.net> <200402282128.i1SLSuY15359@raven.dms.auburn.edu> <200402290224.i1T2Oip15705@raven.dms.auburn.edu> <87sl3fdqs3.fsf@escher.local.home> <87zlxc5r2f.fsf@escher.local.home> <474059CD.1060107@gmx.at> <87r6ihi1z7.fsf@escher.local.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1195827944 801 80.91.229.12 (23 Nov 2007 14:25:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Nov 2007 14:25:44 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 23 15:25:51 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IvZTR-00067G-He for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 15:25:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvZTC-0002VT-Vr for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 09:25:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IvZSn-0002CG-9f for emacs-devel@gnu.org; Fri, 23 Nov 2007 09:25:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IvZSm-0002BP-SG for emacs-devel@gnu.org; Fri, 23 Nov 2007 09:25:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvZSm-0002BE-El for emacs-devel@gnu.org; Fri, 23 Nov 2007 09:25:00 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1IvZSl-0000ld-UO for emacs-devel@gnu.org; Fri, 23 Nov 2007 09:25:00 -0500 Original-Received: (qmail invoked by alias); 23 Nov 2007 14:24:57 -0000 Original-Received: from N940P006.adsl.highway.telekom.at (EHLO [62.47.61.102]) [62.47.61.102] by mail.gmx.net (mp008) with SMTP; 23 Nov 2007 15:24:57 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/3kp1lrFD3Tv8PC6uZbIaBEA45iMsZLcEd/apacG y8fwP+UcjGPGAz User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <87r6ihi1z7.fsf@escher.local.home> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83959 gmane.emacs.pretest.bugs:20348 Archived-At: > With (forward-line -1) there is also no line skipping, > but this is also the case without setting the rear-nonsticky property to > t, i.e., I see no difference, in contrast to C-p. The value of > track-eol is nil (the default). So I am not sure what problems you > mean. Assigning the rear-sticky property affects where `point' is set by scan_newline which does the line-end serching in `forward-line'. Not setting the rear-nonsticky property skips the line ends with the invisible property, at least on my system. Since `previous-line' and `next-line' both rely on `forward-line' to skip lines, I can't imagine how you do not see the problem with the latter. Please try again. > I don't recall this discussion, but in any case Emacs normally does > update the line number display when the cursor moves to another line, > which does not involve buffer modification, so I don't see why > invisibility should make a difference here. My memory was bad, have a look at the thread starting here: http://lists.gnu.org/archive/html/emacs-devel/2006-02/msg00338.html >>In current development Emacs, the cursor stays put, i.e., C-p is a no-op >>>here; the same goes for every position in line 3, except the beginning >>>of the line: here C-p goes to the beginning of line 1 (the parenthetical >>>comment doesn't make sense, unless it is a typo for line 1, or maybe he >>>means the mode line should display L2 instead of L3, even though the >>>cursor stays put). >> >>This seems like a bug in `line-move-finish', please try the attached >>patch (untested). > > > With your patch typing C-p, with the cursor at any position in line 3 > but the beginning of the line, moves the cursor to the beginning of line > 3, i.e., does the same thing as C-a. I think I would have expected it > to put the cursor on line 1. (At the beginning of line 3 the behavior > is as before, C-p goes to the beginning of line 1.) Did you assign the rear-nonsticky property? It won't work without that property due to the behavior of the point setting mechanism. > Summarizing, it appears that rear-nonsticky should be set to t when a > position is given the invisible property. In particular, > facemenu-set-invisible should be changed accordingly, otherwise the menu > choice Edit->Text Properties->Special Properties->Invisible admits the > observed motion misbehavior. (But I don't know if there are other cases > where facemenu-set-invisible should leave the invisible position > rear-sticky.) This still does not fix the problem with C-p at positions > other than the beginning of the line after an invisible line, but your > patch for that also results in unexpected behavior. Setting rear-nonsticky is _not_ sufficient, you have to do something as in my patch in order to handle `line-move-ignore-invisible' correctly. Please try again (1) with the property set, (2) with and without my patch applied, and (3) with both values for `line-move-ignore-invisible' and `track-eol'.