From: Martin Pohlack <mp26@os.inf.tu-dresden.de>
To: bug-gnu-emacs@gnu.org
Subject: Patch for sgml-mode.el
Date: Thu, 22 Nov 2007 14:00:07 +0100 [thread overview]
Message-ID: <47457D57.7010008@os.inf.tu-dresden.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
Hi,
sgml-mode.el currently contains such lines:
(define-derived-mode sgml-mode text-mode '(sgml-xml-mode "XML" "SGML")
and
(define-derived-mode html-mode sgml-mode '(sgml-xml-mode "XHTML" "HTML")
.
This violates that the third argument of define-derived-mode shall be a
string. Furthermore, it results in "mode-name" not being a string for
html buffers.
The attached small patch against current CVS fixes these problems.
Cheers,
Martin Pohlack
[-- Attachment #2: sgml-mode_mode-name-fix.diff --]
[-- Type: text/plain, Size: 880 bytes --]
--- sgml-mode.el 2007-11-22 13:52:32.000000000 +0100
+++ /usr/share/emacs/23.0.60/lisp/textmodes/sgml-mode.el 2007-11-22 13:50:10.000000000 +0100
@@ -408,7 +406,7 @@
(eq (char-before) ?<))))
;;;###autoload
-(define-derived-mode sgml-mode text-mode '(sgml-xml-mode "XML" "SGML")
+(define-derived-mode sgml-mode text-mode (if sgml-xml-mode '"XML" '"SGML")
"Major mode for editing SGML documents.
Makes > match <.
Keys <, &, SPC within <>, \", / and ' can be electric depending on
@@ -1890,7 +1888,7 @@
\f
;;;###autoload
-(define-derived-mode html-mode sgml-mode '(sgml-xml-mode "XHTML" "HTML")
+(define-derived-mode html-mode sgml-mode (if sgml-xml-mode '"XHTML" '"HTML")
"Major mode based on SGML mode for editing HTML documents.
This allows inserting skeleton constructs used in hypertext documents with
completion. See below for an introduction to HTML. Use
reply other threads:[~2007-11-22 13:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47457D57.7010008@os.inf.tu-dresden.de \
--to=mp26@os.inf.tu-dresden.de \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.