From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell Date: Wed, 2 Feb 2022 11:41:33 -0800 Message-ID: <4733b4db-705c-2b52-e1e6-68b0902f87d3@gmail.com> References: <75056e6b-c739-a48c-2bf8-56ddc456da8e@gmail.com> <871r0lrvg1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53715@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 02 21:29:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFMFz-00075p-Iw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Feb 2022 21:29:35 +0100 Original-Received: from localhost ([::1]:35190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFMFy-00032x-4g for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Feb 2022 15:29:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFLWS-0004pc-3h for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 14:42:33 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFLVx-0004X8-No for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 14:42:29 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nFLVx-00089d-Mt for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 14:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Feb 2022 19:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53715 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53715-submit@debbugs.gnu.org id=B53715.164383090331319 (code B ref 53715); Wed, 02 Feb 2022 19:42:01 +0000 Original-Received: (at 53715) by debbugs.gnu.org; 2 Feb 2022 19:41:43 +0000 Original-Received: from localhost ([127.0.0.1]:53700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFLVf-000895-Dj for submit@debbugs.gnu.org; Wed, 02 Feb 2022 14:41:43 -0500 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:52090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFLVd-00088p-0s for 53715@debbugs.gnu.org; Wed, 02 Feb 2022 14:41:42 -0500 Original-Received: by mail-pj1-f50.google.com with SMTP id q63so300720pja.1 for <53715@debbugs.gnu.org>; Wed, 02 Feb 2022 11:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=f5KhAOUmAB4hF6tzerebLSex2nHg1eIqPvg+IkXE2Y4=; b=o2BrCJuKVtmS2xWwsNp5PgX7s+b15rrHOND9p9QmwiqD4tb69lh41V1z29BmiWMQul yHCU8O71oiX5rDG/3UKyff6yX58GtF5L56fi3if3AGwEGpIPFdTw0tj4/rYezp/3mgMg hPNdPYbV7hb1J7axvwsJ8Z5DbS8xfBHrkSPPwulCAx5V0ky0DTasJZwT9QZ/gm84DrJK HE2JWab4G2wCv0psICWw/FavokLeu4PEmc5clcqLqClMLraybk8n7vcq8QrnW0ZSQ0b6 D9vocClJBbF3XjjqJ7tZXAux5xVTLiMVwcciSgJyW35ua9BPSRdHJzQh2JM5bnjBsVFV U17Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f5KhAOUmAB4hF6tzerebLSex2nHg1eIqPvg+IkXE2Y4=; b=ejB2QURIW5uT4tgtxWzreYA/Cjk0ZSDSseYTRmW/JtpoN6K5D5DaEfVXISb7JgOGQs UD/w37HxCnPZvdaJQwGc22VigeJwtXlXwU0Tqt/cPrsBq0dR24aPckmo+yH+x4sSPuOR t6NZi5FR9aYh57ssdpeWzKhO0v9WnDL49Zv3a1IwckWllUkbzAwcB9uE3KFex/0agfzk ivm+9XdRI8HgfI70PY+i+qk7vfdH9ZA3wNNQTCd09iOlqpe/L5z1knDIGC5/o4MOgVxs SqvIDvkz5K/A4oIMM9EmNMquI0Vht54U/KnKbhvZW8NHHjZKyXsP2BAZkftLZ0tDKoQj 9cfw== X-Gm-Message-State: AOAM530a0LW9weDB1uxCPruGNnjhAxbETP2ILpPbr0qNzg4RojOi6uvs kn/DJbiFn6SfEB6hj1xk2E3BdRxR56AIBQ== X-Google-Smtp-Source: ABdhPJygYnJHyOZtZUZKR0N5rt90PzAX9Vyf5N/Q1BuKu2P0ZKWP69d3g19Omm/DmahDmyEZdOsDEQ== X-Received: by 2002:a17:90b:3803:: with SMTP id mq3mr9653454pjb.95.1643830895146; Wed, 02 Feb 2022 11:41:35 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q15sm7165084pjj.19.2022.02.02.11.41.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 11:41:34 -0800 (PST) In-Reply-To: <871r0lrvg1.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225826 Archived-At: On 2/2/2022 10:10 AM, Lars Ingebrigtsen wrote: > These patches seem to lead to a number of tests failing: > > Test eshell-test/last-result-var2 condition: > (void-variable eshell-last-async-proc) > FAILED 22/34 eshell-test/last-result-var2 (0.001074 sec) at lisp/eshell/eshell-tests.el:164 > passed 23/34 eshell-test/lisp-command (0.000350 sec) > passed 24/34 eshell-test/lisp-command-args (0.000308 sec) Sorry, I forgot to mention that since the second patch updates a defsubst (`eshell-interactive-process'), you'll need to recompile all the files that might use it, so `make boostrap' or `touch lisp/eshell/*.el test/lisp/eshell/*.el && make'. That should make these tests pass. Once this merges, I'll send a message to emacs-devel to let everyone know to recompile these files so there are no surprises when they try to use Eshell later on.