From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vinicius Jose Latorre Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; eshell/cd and multiple dots in directory name Date: Thu, 08 Nov 2007 15:16:12 -0300 Message-ID: <4733526C.3010801@ig.com.br> References: <87prysw7bx.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1194542216 8140 80.91.229.12 (8 Nov 2007 17:16:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Nov 2007 17:16:56 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, David Hansen To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 08 18:17:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IqAzs-0002iI-QU for ged-emacs-devel@m.gmane.org; Thu, 08 Nov 2007 18:16:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqAzh-0004ad-8u for ged-emacs-devel@m.gmane.org; Thu, 08 Nov 2007 12:16:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqAzc-0004V9-26 for emacs-devel@gnu.org; Thu, 08 Nov 2007 12:16:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqAzZ-0004ST-U2 for emacs-devel@gnu.org; Thu, 08 Nov 2007 12:16:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqAzZ-0004SB-QF for emacs-devel@gnu.org; Thu, 08 Nov 2007 12:16:33 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IqAzY-0000jW-VL for emacs-devel@gnu.org; Thu, 08 Nov 2007 12:16:33 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IqAzY-0004NC-FF for emacs-pretest-bug@gnu.org; Thu, 08 Nov 2007 12:16:32 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IqAzT-0000gk-Mh for emacs-pretest-bug@gnu.org; Thu, 08 Nov 2007 12:16:31 -0500 Original-Received: from qb-out-0506.google.com ([72.14.204.231]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IqAzS-0000fZ-AT for emacs-pretest-bug@gnu.org; Thu, 08 Nov 2007 12:16:26 -0500 Original-Received: by qb-out-0506.google.com with SMTP id e6so1262787qbe for ; Thu, 08 Nov 2007 09:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; bh=ssC6Ddpppkb3/EHsQ9qAexZj7dW3/QHzS30b9puULpU=; b=AsIsPOKM2RYW0opLEkTwtmM5pCJCjjKSGd3rCkXS7X4bEcDPVcWqibrDy1taHBB9baChMGdBfvnV9W1FrlSbl620Pdhqt2mNhp+TyhSDLhKErHjdJLyyiXdtiUhWSL4SJuvqKH9amUdUqM/1jJDG4Ul80qLSEKi6Ub6Zb/8aN0s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=MCq6knM5PdCH7SOBwfvexiw0XxHb4h1HeQOAdAPILE9scFmywXuQwMg99CJUanlUVpUFtL01yBERZXODSMGYH9Hfs/3eSLTWYsvId/qFZwWx21rhJtbTNIm/rycm8VZ3ATKtg1t5zjzwRIEkmU/CJeof+nQeFRAFjgTH5jXHSDM= Original-Received: by 10.100.241.17 with SMTP id o17mr1196805anh.1194542183104; Thu, 08 Nov 2007 09:16:23 -0800 (PST) Original-Received: from ?192.168.0.100? ( [201.82.228.153]) by mx.google.com with ESMTPS id i27sm304142elf.2007.11.08.09.16.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 08 Nov 2007 09:16:20 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071009 SeaMonkey/1.1.5 In-Reply-To: X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82811 gmane.emacs.pretest.bugs:20254 Archived-At: Richard Stallman wrote: > I'd like someone to install this on Nov 8 > if nobody points out a problem with it before then. > Done in trunk and emacs_22_branch. > From: David Hansen > To: emacs-pretest-bug@gnu.org > Organization: disorganized > Date: Sat, 03 Nov 2007 00:33:54 +0100 > MIME-Version: 1.0 > Content-Type: multipart/mixed; boundary="=-=-=" > Cc: > Subject: 23.0.50; eshell/cd and multiple dots in directory name > > --=-=-= > > > Please write in English if possible, because the Emacs maintainers > usually do not have translators to read other languages for them. > > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. > > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: > > Hello, > > to reproduce: > > $ emacs -Q > > M-x eshell RET > $ cd /tmp > $ mkdir a...b > $ cd a...b > No such directory found via CDPATH environment variable > > The error is caused by a call to `eshell-expand-multiple-dots' in > `eshell/cd'. I'm not quite sure what the use of > `eshell-expand-multiple-dots' is. A quick grep says it's only used in > `eshell/cd'. So I suggest the following short patch: > > > --=-=-= > Content-Type: text/x-patch > Content-Disposition: inline > > Index: em-dirs.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/eshell/em-dirs.el,v > retrieving revision 1.21 > diff -c -r1.21 em-dirs.el > *** em-dirs.el 26 Jul 2007 05:26:53 -0000 1.21 > --- em-dirs.el 2 Nov 2007 23:30:36 -0000 > *************** > *** 319,325 **** > (before translate-multiple-dots > (filename &optional directory) activate) > (setq filename (eshell-expand-multiple-dots filename)))" > ! (while (string-match "\\.\\.\\(\\.+\\)" path) > (let* ((extra-dots (match-string 1 path)) > (len (length extra-dots)) > replace-text) > --- 319,325 ---- > (before translate-multiple-dots > (filename &optional directory) activate) > (setq filename (eshell-expand-multiple-dots filename)))" > ! (while (string-match "\\(?:^\\|/\\)\\.\\.\\(\\.+\\)\\(?:$\\|/\\)" path) > (let* ((extra-dots (match-string 1 path)) > (len (length extra-dots)) > replace-text) > > > Diffs between working revision and workfile end here. > --=-=-= > > > Actually I suggest to drop this confusing feature or at least implement > it everywhere in eshell (`eshell/ls', `eshell/cp', ...). > > David > > If Emacs crashed, and you have the Emacs process in the gdb debugger, > please include the output from the following gdb commands: > `bt full' and `xbacktrace'. > If you would like to further debug the crash, please read the file > /home/dhansen/share/emacs/23.0.50/etc/DEBUG for instructions. > > > In GNU Emacs 23.0.50.1 (i686-pc-linux-gnu) > of 2007-10-28 on robotron > Windowing system distributor `The X.Org Foundation', version 11.0.10400000 > configured using `configure '--prefix=/home/dhansen' '--disable-sound' '--disable-pop' '--with-x-toolkit=no'' > > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: en_US.UTF-8 > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: en_US.UTF-8 > locale-coding-system: utf-8 > default-enable-multibyte-characters: t > > Major mode: Emacs-Lisp > > Minor modes in effect: > shell-dirtrack-mode: t > paredit-mode: t > TeX-PDF-mode: t > jabber-activity-mode: t > eldoc-mode: t > which-function-mode: t > show-paren-mode: t > iswitchb-mode: t > tooltip-mode: t > mouse-wheel-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > unify-8859-on-encoding-mode: t > utf-translate-cjk-mode: t > auto-compression-mode: t > line-number-mode: t > abbrev-mode: 1 > hs-minor-mode: t > > Recent input: > > > > C-p C-p C-a RET C-x 1 C-n C-n > C-e C-a d SPC C-c m C-x 1 C-n > q g C-n C-n C-n C-n C-n > C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n > C-n C-n C-n C-n RET RET q M-x r g r > C-g g C-g f C-h f r g r e p > q C-g g C-z c d SPC t m m k > d i r SPC a . . . b c d SPC a . . . b > C-h f e s h e l l / c d C-c f > C-u C-c f C-g C-c f f C-c f f C-c f e C-c d C-g C-c > g C-g C-c g C-g C-c v f C-x C-f ~ / d o > e m c o n e m d o > e m C-s f i n d - f u n C-a C-z f i > n d - f u n d c C-a C-k > > C-n C-n C-n C-n C-n C-n C-u C-M-x > M-p n > C-x 1 C-x b > n n n n n n n n n n n n n n n n n n n n n n n n n n > n N G C-x b C-s m u l M-b M-b C-c > C-f f C-n C-n C-n C-n C-n M-x r e p o r > b u g > > Recent messages: > Result: nil [2 times] > Result: "a...b" [2 times] > Result: "a../..b" > edebug-recursive-edit: Buffer is read-only: # > Go-Nonstop... > Mark saved where search started > uncompressing em-dirs.el.gz...done > Fontifying em-dirs.el.gz... (regexps...........................) > uncompressing em-dirs.el.gz...done > Auto-saving...done > > --=-=-= > Content-Type: text/plain; charset="us-ascii" > MIME-Version: 1.0 > Content-Transfer-Encoding: 7bit > Content-Disposition: inline > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel > --=-=-=-- >