From: martin rudalics <rudalics@gmx.at>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] proposal tiny cleanup for window code
Date: Wed, 07 Nov 2007 13:57:01 +0100 [thread overview]
Message-ID: <4731B61D.7040106@gmx.at> (raw)
In-Reply-To: <47319A3B.7030200@yandex.ru>
> I've found that too_small_ok member of struct window isn't used anywhere
> except size_window,
> so it looks like there are no reasons to have too_small_ok within struct
> window...
I fail to understand the use of that but the current code reads as
if (old_size < min_size && nodelete_p != 2)
w->too_small_ok = Qt;
/* Move the following test here since otherwise the
preceding test doesn't make sense. martin. */
if (nodelete_p == 2)
nodelete_p = 0;
/* Maybe delete WINDOW if it's too small. */
if (nodelete_p != 1 && !NILP (w->parent))
{
if (!MINI_WINDOW_P (w) && !NILP (w->too_small_ok))
hence too_small_ok is never set to t when nodelete_p initially equals 2.
With your change this becomes
/* Move the following test here since otherwise the
preceding test doesn't make sense. martin. */
if (nodelete_p == 2)
nodelete_p = 0;
/* Maybe delete WINDOW if it's too small. */
if (nodelete_p != 1 && !NILP (w->parent))
{
if (!MINI_WINDOW_P (w) && old_size < min_size && nodelete_p != 2)
hence (the "implied") too_small_ok can be set to t when nodelete_p
initially equals 2 and your version is not semantically equivalent to
the previous one. Please verify again.
next prev parent reply other threads:[~2007-11-07 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 10:58 [patch] proposal tiny cleanup for window code Dmitry Antipov
2007-11-07 12:57 ` martin rudalics [this message]
2007-11-07 13:32 ` Dmitry Antipov
2007-11-07 15:38 ` martin rudalics
2007-11-08 4:42 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4731B61D.7040106@gmx.at \
--to=rudalics@gmx.at \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.