Issues with Emacs master?

Issues with Emacs master?

[Angelo Graziosi]

After about a month, I have built master (b49d98, 2019-08-02 12:24:53) and noticed that with Python files (.py) it flags

  "Can’t guess python-indent-offset, using defaults: 4"

(in the minibuffer or in Messages). Really this message is present also in previous builds but in the current, if I try

C-h v pyth TAB

(to know about python-indent-offset) I get in the minibuffer, 

- on Windows (MSYS2/MINGW64 build):

  "Shell native completion is disabled, using fallback"

- on GNU/Linux Mint 19.1 (Cairo build):

  "Shell native completion is enabled."

It seems that these message show up only if the variable start with the string 'py' or 'pyt' or 'pyth' etc. Trying with 'pr', 'pri'.. 'ps', 'ps-sp'.. there is the completion without any message..

In previous builds (2019-06-30 11:23:06), on both systems, no message but the completion oh pyth in python- etc.

Maybe a python-mode regression/issue

Ciao,  
  Angelo.

Re: Issues with Emacs master?

[Noam Postavsky]

On Fri, 2 Aug 2019 at 10:53, Angelo Graziosi <angelo.g0@libero.it> wrote:

> C-h v pyth TAB
>
> (to know about python-indent-offset) I get in the minibuffer,
>
> - on Windows (MSYS2/MINGW64 build):
>
>   "Shell native completion is disabled, using fallback"
>
> - on GNU/Linux Mint 19.1 (Cairo build):
>
>   "Shell native completion is enabled."
>
> It seems that these message show up only if the variable start with the string 'py' or 'pyt' or 'pyth' etc. Trying with 'pr', 'pri'.. 'ps', 'ps-sp'.. there is the completion without any message..

Completing symbol names may load files, see Bug#28607.

https://debbugs.gnu.org/28607

Re: Issues with Emacs master?

[Angelo Graziosi]

> Il 2 agosto 2019 alle 16.59 Noam Postavsky ha scritto:
> 
> 
> On Fri, 2 Aug 2019 at 10:53, Angelo Graziosi wrote:
> 
> > C-h v pyth TAB
> >
> > (to know about python-indent-offset) I get in the minibuffer,
> >
> > - on Windows (MSYS2/MINGW64 build):
> >
> >   "Shell native completion is disabled, using fallback"
> >
> > - on GNU/Linux Mint 19.1 (Cairo build):
> >
> >   "Shell native completion is enabled."
> >
> > It seems that these message show up only if the variable start with the string 'py' or 'pyt' or 'pyth' etc. Trying with 'pr', 'pri'.. 'ps', 'ps-sp'.. there is the completion without any message..
> 
> Completing symbol names may load files, see Bug#28607.
> 
> https://debbugs.gnu.org/28607

For some strange reason, I didn't notice it in previous builds... Thanks.

Re: Issues with Emacs master?

[Stefan Monnier]

>> C-h v pyth TAB
>>
>> (to know about python-indent-offset) I get in the minibuffer,
>>
>> - on Windows (MSYS2/MINGW64 build):
>>
>>   "Shell native completion is disabled, using fallback"
>>
>> - on GNU/Linux Mint 19.1 (Cairo build):
>>
>>   "Shell native completion is enabled."
>>
>> It seems that these message show up only if the variable start with the
>> string 'py' or 'pyt' or 'pyth' etc. Trying with 'pr', 'pri'.. 'ps',
>> 'ps-sp'.. there is the completion without any message..
>
> Completing symbol names may load files, see Bug#28607.
>
> https://debbugs.gnu.org/28607

I suggest using debug-on-message to catch the file that causes those
messages when loaded, and then file a bug report about it.


        Stefan

Re: Issues with Emacs master?

[Andreas Röhler]

On 02.08.19 22:27, Stefan Monnier wrote:
>>> C-h v pyth TAB
>>>
>>> (to know about python-indent-offset) I get in the minibuffer,
>>>
>>> - on Windows (MSYS2/MINGW64 build):
>>>
>>>    "Shell native completion is disabled, using fallback"
>>>
>>> - on GNU/Linux Mint 19.1 (Cairo build):
>>>
>>>    "Shell native completion is enabled."
>>>
>>> It seems that these message show up only if the variable start with the
>>> string 'py' or 'pyt' or 'pyth' etc. Trying with 'pr', 'pri'.. 'ps',
>>> 'ps-sp'.. there is the completion without any message..
>> Completing symbol names may load files, see Bug#28607.
>>
>> https://debbugs.gnu.org/28607
> I suggest using debug-on-message to catch the file that causes those
> messages when loaded, and then file a bug report about it.
>
>
>          Stefan
>
>

Customizing `python-indent-guess-indent-offset-verbose` to nil should 
avoid this message. IMO nil by default seems reasonable.

Re: Issues with Emacs master?

[Stefan Monnier]

>>>> (to know about python-indent-offset) I get in the minibuffer,
>>>> - on Windows (MSYS2/MINGW64 build):
>>>>    "Shell native completion is disabled, using fallback"
>>>> - on GNU/Linux Mint 19.1 (Cairo build):
>>>>    "Shell native completion is enabled."
[...]
> Customizing `python-indent-guess-indent-offset-verbose` to nil should avoid
> this message. IMO nil by default seems reasonable.

Hmm, the code I see for it is:

    python.el-      (if (and indentation (not (zerop indentation)))
    python.el-          (set (make-local-variable 'python-indent-offset) indentation)
    python.el:        (when python-indent-guess-indent-offset-verbose
    python.el-          (message "Can't guess python-indent-offset, using defaults: %s"
    python.el-                   python-indent-offset))))))))

so the message it controls seems to be quite different from the message
that the OP sees.


        Stefan

Re: Issues with Emacs master?

[Andreas Röhler]

On 05.08.19 21:44, Stefan Monnier wrote:
>>>>> (to know about python-indent-offset) I get in the minibuffer,
>>>>> - on Windows (MSYS2/MINGW64 build):
>>>>>     "Shell native completion is disabled, using fallback"
>>>>> - on GNU/Linux Mint 19.1 (Cairo build):
>>>>>     "Shell native completion is enabled."
> [...]
>> Customizing `python-indent-guess-indent-offset-verbose` to nil should avoid
>> this message. IMO nil by default seems reasonable.
> Hmm, the code I see for it is:
>
>      python.el-      (if (and indentation (not (zerop indentation)))
>      python.el-          (set (make-local-variable 'python-indent-offset) indentation)
>      python.el:        (when python-indent-guess-indent-offset-verbose
>      python.el-          (message "Can't guess python-indent-offset, using defaults: %s"
>      python.el-                   python-indent-offset))))))))
>
> so the message it controls seems to be quite different from the message
> that the OP sees.
>
>
>          Stefan
>
Referred to mentioned

"Can’t guess python-indent-offset, using defaults: 4"

BTW that's a thing noticed here too for a certain time.

Not a serious bug, but not helpful, worth fixing.

Guessing indent OTOH is costly and reasonably off by default.

Re: Issues with Emacs master?

[Stefan Monnier]

> Referred to mentioned
>
> "Can’t guess python-indent-offset, using defaults: 4"

Ah, right.  I skipped this part because he said it's been there for much
longer.  IOW it's a separate issue from the one that caused him to
report the bug.

> Guessing indent OTOH is costly and reasonably off by default.

I don't have a strong opinion on that, but the variable you pointed to
doesn't disable the guess, it only disables the message emitted at the
end of the guess.  To disable the guess you need to set
python-indent-guess-indent-offset, IIUC.


        Stefan

Re: Issues with Emacs master?

[Angelo Graziosi]

> Andreas Röhler wrote:
> 
> Customizing `python-indent-guess-indent-offset-verbose` to nil should > avoid this message

> Stefan Monnier wrote:
>
> so the message it controls seems to be quite different from the
> message that the OP sees

Just for completeness, I added 

  (setq python-indent-guess-indent-offset-verbose nil)

to the init.el file and now I cannot find

  "Can’t guess python-indent-offset, using defaults: 4"

in Messages buffer...