From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#1259: quit-window: does it quit the wrong buffer? Date: Tue, 4 Nov 2008 12:40:47 -0500 Message-ID: <4727ECB9-A38C-4717-AFE5-2CED845C1C50@gmail.com> References: <49059893.3020006@gmx.at> <4757158C-5312-498F-94C6-7A34C0BEFC59@gmail.com> <4905F558.7070005@gmx.at> Reply-To: David Reitter , 1259@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v929.2) Content-Type: multipart/signed; boundary=Apple-Mail-100-552628433; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1225821055 2297 80.91.229.12 (4 Nov 2008 17:50:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Nov 2008 17:50:55 +0000 (UTC) Cc: 1259@emacsbugs.donarmstrong.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 04 18:51:47 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KxQ3q-00005l-RT for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Nov 2008 18:51:27 +0100 Original-Received: from localhost ([127.0.0.1]:44899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxQ2j-0006k4-DJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Nov 2008 12:50:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KxQ2e-0006jo-PP for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 12:50:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KxQ2b-0006jc-8b for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 12:50:11 -0500 Original-Received: from [199.232.76.173] (port=54650 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxQ2b-0006jZ-07 for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 12:50:09 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40101) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KxQ2a-000706-OU for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 12:50:09 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA4Ho5GR021255; Tue, 4 Nov 2008 09:50:05 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mA4Ho3X5021158; Tue, 4 Nov 2008 09:50:03 -0800 X-Loop: don@donarmstrong.com Resent-From: David Reitter Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 04 Nov 2008 17:50:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1259 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1259-submit@emacsbugs.donarmstrong.com id=B1259.122582045519840 (code B ref 1259); Tue, 04 Nov 2008 17:50:03 +0000 Original-Received: (at 1259) by emacsbugs.donarmstrong.com; 4 Nov 2008 17:40:55 +0000 Original-Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.191]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA4HeqhN019834 for <1259@emacsbugs.donarmstrong.com>; Tue, 4 Nov 2008 09:40:53 -0800 Original-Received: by rn-out-0910.google.com with SMTP id j66so2484790rne.20 for <1259@emacsbugs.donarmstrong.com>; Tue, 04 Nov 2008 09:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=pQENMdb/K/7NXGZ5B+bgh/MPPYQuzz6bYaqIquM8Mac=; b=gO4bef+fZ03PWy9iHO5/CHfZB56S7i4aI7IaacefD00b75/jA/Q5JCrV24Y032HSX5 xT4+nTW21nAkYkS9ylLKemaNRd32nxmxlF+Qx22LnmpnqgrlCot9yoYBaQk7Aa3uoEPC orF2OQMahOwceSaopz6SQ+nz3M7oQRiTdTdEQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=icaX/VJncfGwIGuo5uJMB6qSjFvKSNWAZttcaz7sJWUDLWKawzbIkirm700SYcrukM NAoY9C80gTwLCSKhmGOU8Q77u0gq3tBNhCRFYqM7rsQQMcahu61WurtvTQKuoa3qWLK1 GZdAFruqL2UXPHI2P/IcAOO0AU+GhTXwM6GDw= Original-Received: by 10.100.46.10 with SMTP id t10mr870174ant.136.1225820451670; Tue, 04 Nov 2008 09:40:51 -0800 (PST) Original-Received: from SCARLETT.PSY.CMU.EDU (SCARLETT.PSY.CMU.EDU [128.2.249.106]) by mx.google.com with ESMTPS id d24sm1046218and.4.2008.11.04.09.40.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 04 Nov 2008 09:40:50 -0800 (PST) In-Reply-To: <4905F558.7070005@gmx.at> X-Mailer: Apple Mail (2.929.2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 04 Nov 2008 12:50:11 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22161 Archived-At: --Apple-Mail-100-552628433 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Sorry for the delay. On 27 Oct 2008, at 13:07, martin rudalics wrote: > `quit-window' looks fishy in a number of regards: The `delete-frame' > stuff needs other_visible_frames to work correctly but this is not > available in Elisp. I plan to commit somthing like the version below. > Could people please test whether it breaks their favorite use of this? Is there a reason why you're not calling delete-window-on in all cases? Why the condition-case only for delete-window? Also, why the explicit switch-to-buffer? Should quit-window switch to the buffer that would be displayed if the current buffer was killed or just buried? - David > > > (defun quit-window (&optional kill window) > "Bury or kill (with KILL non-nil) the buffer displayed in WINDOW. > KILL defaults to nil, WINDOW to the selected window. If WINDOW > is dedicated or a minibuffer window, delete it and, if it's the > only window on its frame, delete its frame as well provided there > are other frames left. Otherwise, display some other buffer in > the window." > (interactive) > (let* ((window (or window (selected-window))) > (buffer (window-buffer window))) > (if (or (window-minibuffer-p window) (window-dedicated-p window)) > (if (eq window (frame-root-window (window-frame window))) > ;; If this is the only window on its frame, try to delete the > ;; frame (`delete-windows-on' knows how to do that). > (delete-windows-on buffer (selected-frame)) > ;; Other windows are left, delete this window. But don't > ;; throw an error if that fails for some reason. > (condition-case nil > (delete-window window) > (error nil))) > ;; The window is neither dedicated nor a minibuffer window, > ;; display another buffer in it. > (with-selected-window window > (switch-to-buffer (other-buffer)))) > > ;; Deal with the buffer. > (if kill > (kill-buffer buffer) > (bury-buffer buffer)))) > --Apple-Mail-100-552628433 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICEEfSZyInpN9bVdFPsdICbiIwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MTIwOTIzMDM0OFoXDTA4MTIwODIzMDM0 OFowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDIS4kZGULD+CxprkxDnEccAnZ2GQQxfn55aiAPoy5kJ+uLhelaZP4p lgx3Vq8xYK1bjsLepGYp8qzVlHsyQPb6OfvRzrUXHxlJrHME0+Lblx37PBLxGDxc5W8qfZFJpej8 Dk3LUMga8laR9CRghbALoTV3UThUSMqk1cVwTY99KQIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAKU8XIS6 R/R3Hg6ae5p0i4iUJURq+sDVMX9RGB3Ge5V8oKKglIQGaY03leem65pqICL6mdgX/Px21JoaKVAA 8XITLFVEFHL6BfZ/eePnzNi93rnaNe7hLUwLdGztdYmqN8zF0DOCybL1M1JDB3cTr0XwHJwxziSf oEeENGNETykjMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBH0mciJ6TfW1XR T7HSAm4iMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA4MTEwNDE3NDA0OFowIwYJKoZIhvcNAQkEMRYEFL2Q1qmBQbEajJnddSbHwhOfvtKX MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQR9JnIiek31tV0U+x0gJuIjCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQR9JnIiek31tV0U+x0gJuIjANBgkqhkiG9w0B AQEFAASBgKmTqMBau3vXSGg776PZ2V3NFd0Pu3MnEMJLhvi8EMBKceIgNpZXI0huXliCrfvwUk77 9UWTwklOB/5pMPg6kv3HDE0hO4N9V82SDJ9ZVsEBM5a1Tespf8rC/WL+Q2ERuz1XfNYvKuHfaz4R sLChOy7VZYd7lRRT0+g7/9JpFQCvAAAAAAAA --Apple-Mail-100-552628433--