From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t Date: Wed, 24 Oct 2007 08:32:09 +0200 Message-ID: <471EE6E9.8020109@gmx.at> References: <70FBB428-1B37-4C3B-A60D-E3A7139E384C@gmail.com> <4711D670.6060508@gmx.at> <4717174B.2040103@gmx.at> <4717D837.6040706@gmx.at> <4718674A.1080505@gmx.at> <4719CE56.6020301@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1193208393 20950 80.91.229.12 (24 Oct 2007 06:46:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2007 06:46:33 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, dashteacup@insightbb.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 24 08:46:34 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ika0f-0008IZ-Eb for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2007 08:46:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ika0X-0004JA-5r for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2007 02:46:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ika0V-0004Ha-AT for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2007 02:46:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ika0T-0004G3-UI for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2007 02:46:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ika0T-0004Fu-NU for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2007 02:46:21 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Ika0T-0003RJ-5b for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2007 02:46:21 -0400 Original-Received: (qmail invoked by alias); 24 Oct 2007 06:46:19 -0000 Original-Received: from N947P024.adsl.highway.telekom.at (EHLO [62.47.62.88]) [62.47.62.88] by mail.gmx.net (mp017) with SMTP; 24 Oct 2007 08:46:19 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+yHp8Clheygrk5RYhwsVZgfbqGPJK4FWZZosS/O8 yweQEzHK4KLQrX User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16823 Archived-At: >>>emacs -Q >>>C-h find-file >>>C-x 1 >>>C-x b *Help* >>>q >>> >>>-> "q" has no effect at all >> >>I cannot reproduce this, my Emacs has "q" display *scratch* instead. > > > I see the above behaviour in Emacs-22.1. After applying your patches, > it's better in that the above works correctly, but if I repeat the > `C-x b *Help*' a second time, then `q' has no effect. Do you see that? Yes. The problem is that `view-exit-action' is reset to nil after exiting once. This is hardly TRT when the buffer is _not_ killed. Hence we could simplify the tail of `view-mode-exit' to (when exit-action (funcall exit-action buffer)) (force-mode-line-update)))) Since `view-exit-action' is buffer-local I don't see any problems either when the buffer _is_ killed.