all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Glenn Morris <rgm@gnu.org>
Cc: bug-gnu-emacs@gnu.org, dashteacup@insightbb.com
Subject: Re: View-quit in *Help* restores wrong window when	display-buffer-reuse-frames is t
Date: Wed, 24 Oct 2007 08:32:09 +0200	[thread overview]
Message-ID: <471EE6E9.8020109@gmx.at> (raw)
In-Reply-To: <kj1wbl5rym.fsf@fencepost.gnu.org>

 >>>emacs -Q
 >>>C-h find-file
 >>>C-x 1
 >>>C-x b *Help*
 >>>q
 >>>
 >>>-> "q" has no effect at all
 >>
 >>I cannot reproduce this, my Emacs has "q" display *scratch* instead.
 >
 >
 > I see the above behaviour in Emacs-22.1. After applying your patches,
 > it's better in that the above works correctly, but if I repeat the
 > `C-x b *Help*' a second time, then `q' has no effect. Do you see that?

Yes.  The problem is that `view-exit-action' is reset to nil after
exiting once.  This is hardly TRT when the buffer is _not_ killed.
Hence we could simplify the tail of `view-mode-exit' to

       (when exit-action
	(funcall exit-action buffer))
       (force-mode-line-update))))

Since `view-exit-action' is buffer-local I don't see any problems either
when the buffer _is_ killed.





  reply	other threads:[~2007-10-24  6:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <D64B7FD7-2C5F-4A87-8F0B-61EB47217262@insightbb.com>
2007-10-13 17:28 ` View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t David Reitter
2007-10-14  8:42   ` martin rudalics
2007-10-17 20:58     ` Glenn Morris
2007-10-18  8:20       ` martin rudalics
2007-10-18 16:05         ` Drew Adams
2007-10-18 22:01           ` martin rudalics
2007-10-18 22:58             ` Drew Adams
2007-10-19  8:23               ` martin rudalics
2007-10-19 15:17                 ` Drew Adams
2007-10-20  9:45                   ` martin rudalics
2007-10-18 18:27         ` Glenn Morris
2007-10-18 22:03           ` martin rudalics
2007-10-18 23:44             ` Glenn Morris
2007-10-19  8:14               ` martin rudalics
2007-10-19 17:52                 ` Glenn Morris
2007-10-20  9:45                   ` martin rudalics
2007-10-23 23:30                     ` Glenn Morris
2007-10-24  6:32                       ` martin rudalics [this message]
2007-10-22 21:45     ` David Reitter
2007-11-29  9:05     ` David Reitter
2007-11-29 10:22       ` martin rudalics
     [not found]       ` <mailman.4303.1196332542.18990.bug-gnu-emacs@gnu.org>
2007-12-01  8:01         ` David Reitter
2007-12-01  9:20           ` martin rudalics
2007-12-01 14:44             ` David Reitter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471EE6E9.8020109@gmx.at \
    --to=rudalics@gmx.at \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=dashteacup@insightbb.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.