From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: nuxdoors@cegetel.net
Newsgroups: gmane.emacs.bugs
Subject: Re: reindent-then-newline-and-indent doesn't indent properly in
 emacs 22.1
Date: Fri, 19 Oct 2007 03:07:17 +0200
Message-ID: <47180345.70401@cegetel.net>
References: <470FFCF1.5050201@cegetel.net> <4710849B.30104@gmx.at>
	<471145BA.6050600@cegetel.net> <E1IhEts-0001s2-JV@fencepost.gnu.org>
	<471400AD.90805@cegetel.net> <E1Ihrnc-0001Ms-3H@fencepost.gnu.org>
	<47152179.5020502@cegetel.net> <E1Ii13p-0002HF-Q4@fencepost.gnu.org>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7BIT
X-Trace: ger.gmane.org 1192756206 29815 80.91.229.12 (19 Oct 2007 01:10:06 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 19 Oct 2007 01:10:06 +0000 (UTC)
Cc: bug-gnu-emacs@gnu.org
To: rms@gnu.org, monnier@IRO.UMontreal.CA
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 19 03:10:06 2007
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IigNH-0006gL-TZ
	for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Oct 2007 03:10:04 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1IigNA-0004ZR-FL
	for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2007 21:09:56 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IigN4-0004Y2-8g
	for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2007 21:09:50 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IigN3-0004Wm-9P
	for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2007 21:09:49 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IigN2-0004WY-V9
	for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2007 21:09:49 -0400
Original-Received: from sp604002mt.neufgp.fr ([84.96.92.61] helo=sMtp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <nuxdoors@cegetel.net>)
	id 1IigMv-0002zB-Vj; Thu, 18 Oct 2007 21:09:42 -0400
Original-Received: from [86.77.74.224] by sp604002mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0JQ40012NWHWTMU1@sp604002mt.gpm.neuf.ld>; Fri,
	19 Oct 2007 03:08:21 +0200 (CEST)
In-reply-to: <E1Ii13p-0002HF-Q4@fencepost.gnu.org>
User-Agent: Icedove 1.5.0.12 (X11/20070607)
X-detected-kernel: by monty-python.gnu.org: Windows 98 (3
X-BeenThere: bug-gnu-emacs@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Bug reports for GNU Emacs,
	the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.bugs:16784
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/16784>

Here is a concrete example to illustrate my previous remark with respect
to the need of removing spaces around point when calling
delete-horizontal-space.

Tested with GNU Emacs 23.0.50.1 (with the new
reindent-then-newline-and-indent)

Let's create indentation_test.txt like this :

cat > indentation_test.txt <<EOF
    First line.
    Second line.
1234 -- columns
EOF

emacs was called like this :
emacs -Q -nw indentation_test.txt

"_" represents a space, "|" represents cursor position.
Place the cursor on the fourth column ( on the space preceding "S" ),
like this :

____First line.
___|Second line.
1234 -- columns

Then do a reindent-then-newline-and-indent, you will get this :

____First line.
_
____|Second line.
1234 -- columns

With the previous version of reindent-then-newline-and-indent you would
get this :

____First line.

____|Second line.
1234 -- columns

The patch to restore previous behavior that works for me :

*** lisp/simple.el.orig Thu Oct 18 06:52:06 2007
--- lisp/simple.el      Fri Oct 19 02:41:22 2007
***************
*** 636,642 ****
        ;; Usually indent-according-to-mode should "preserve" point, but
it is
        ;; not guaranteed; e.g. indent-to-left-margin doesn't.
        (save-excursion (indent-according-to-mode))
!       (delete-horizontal-space t))
      (indent-according-to-mode)))

  (defun quoted-insert (arg)
--- 636,644 ----
        ;; Usually indent-according-to-mode should "preserve" point, but
it is
        ;; not guaranteed; e.g. indent-to-left-margin doesn't.
        (save-excursion (indent-according-to-mode))
!       ;; Delete forward too in case reindent-then-newline-and-indent
!       ;; was called while point was within the line indentation.
!       (delete-horizontal-space))
      (indent-according-to-mode)))

  (defun quoted-insert (arg)