From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t Date: Thu, 18 Oct 2007 10:20:27 +0200 Message-ID: <4717174B.2040103@gmx.at> References: <70FBB428-1B37-4C3B-A60D-E3A7139E384C@gmail.com> <4711D670.6060508@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1192695734 14561 80.91.229.12 (18 Oct 2007 08:22:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2007 08:22:14 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, dashteacup@insightbb.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 18 10:22:14 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IiQdP-0006aj-4i for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2007 10:21:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IiQdI-00087y-0w for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2007 04:21:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IiQdB-00087d-Pn for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2007 04:21:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IiQd7-00086Z-LE for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2007 04:21:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IiQd7-00086V-Iu for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2007 04:21:21 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1IiQd6-0007ey-RV for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2007 04:21:21 -0400 Original-Received: (qmail invoked by alias); 18 Oct 2007 08:21:18 -0000 Original-Received: from N824P030.adsl.highway.telekom.at (EHLO [62.47.46.254]) [62.47.46.254] by mail.gmx.net (mp048) with SMTP; 18 Oct 2007 10:21:18 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18eyBh39UseWCVCKjGD35cvBds0J4Vro78TkKHxhA Eyul51qXFLQeXi User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16776 Archived-At: > I tried your patch. It fixes this problem and the problem in the > thread where you originally posted it. Is there anything else I should > test? Thanks for testing. So far I identified four groups of users: (1) The one window one frame minimalist has `pop-up-frames' and `pop-up-windows' both and would like exiting view-mode to restore the window shown before. (2) The one window per frame type has `pop-up-frames' non-nil and `pop-up-windows' nil and expects view-mode to pop up a new or reuse an existing frame. (3) The at most two windows per frame user has `pop-up-windows' non-nil and `split-height-threshold' the default. Such users expect view-mode to reuse any "other window" on the present frame regardless of its mode. (4) The many windows per frame user has `pop-up-windows' non-nil and customized `split-height-threshold' appropriately. Users in this group expect view-mode to reuse an existing window on the same frame iff it's a view-mode window. My changes should set up information for exiting view mode correctly for all of them. The message printed when entering view-mode should be correct with respect to how to scroll the help window and how to get rid of its contents. I have tried to test these but might have failed to specify usage patterns correctly. Maybe there's also another group of users I failed to identify so far. In addition my changes should cope with the following: - Exiting view-mode should ideally (1) kill a window that has been popped up for view-mode purposes and (2) show the earlier contents of the window when it has been usurpated by view-mode. - Exit information should not get overwritten when following links, hitting backward/forward buttons and the like (including Nick's `help-xref-go-forward'). - Something reasonable should be done when a user manually switches to a view-mode buffer and types `q' in that buffer. Hard to get right for a type (2) user who intermittently displays some unrelated buffer in a view-mode window, manually switches back to the view-mode buffer, and types `q'. What should I do here? Kill the frame, display the other buffer and possibly lower the frame, iconify the frame, `bury-buffer', `quit-window', ... - Is the `help-window-select' option useful? The OP of the present thread had the usage pattern (progn (setq display-buffer-reuse-frames t) (describe-mode) (other-window 1) (View-quit) ) With `help-window-select' non-nil, the `other-window' is not needed. Getting some feedback in these areas would be very helpful. Also, I'd eventually want to get rid of all `print-help-return-message' instances in the Elisp base including vhdl and python mode. I have to check these case by case though. If I can get these right I'd finally like quitting *info* and other temporary windows do something similar.